Better Phabricator API requests handling
ClosedPublic
Actions

Authored by dereckson on Dec 25 2015, 19:45.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF06d52a204908: Better Phabricator API requests handling

Summary

We don't try to guess if the API reply will be an object with the
PHID as key, or an array with 0 as offset for our reply, or an object
with 0 as property.

Instead, we call PhabricatorAPI::getFirstResult() method.

Test Plan

With this change, the development server fired notifications
for pending requests.

19:42:09 < Wearg> dereckson accepted D117: PHPMD: composer phpmd.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 285.Dec 25 2015, 19:45

dereckson retitled this revision from to Better Phabricator API requests handling.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Dec 25 2015, 19:47

dereckson edited edge metadata.

This revision is now accepted and ready to land.Dec 25 2015, 19:47

Closed by commit rNOTIF06d52a204908: Better Phabricator API requests handling (authored by dereckson, committed by dereckson). · Explain WhyDec 25 2015, 19:47

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorStory.php

10 lines

Diff 286

View Options

app/Phabricator/PhabricatorStory.php

Better Phabricator API requests handlingClosedPublicActions