Page MenuHomeDevCentral

Refactor Phabricator event and last payload save code
ClosedPublic

Authored by dereckson on Dec 25 2015, 19:53.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 20:43
Unknown Object (File)
Fri, Nov 8, 01:05
Unknown Object (File)
Thu, Nov 7, 10:43
Unknown Object (File)
Thu, Nov 7, 10:31
Unknown Object (File)
Sun, Oct 27, 04:35
Unknown Object (File)
Mon, Oct 21, 04:54
Unknown Object (File)
Mon, Oct 21, 04:33
Unknown Object (File)
Oct 10 2024, 15:05
Subscribers
None

Details

Summary

The Phabricator event now uses a payload property like the others
...PayloadEvent classes, and is now responsible to initialize
an instance of PhabricatorStory itself.

With a payload property, we are now able to use LastPayloadSaver
for all our payload events.

Test Plan
  • Wait a Phabricator request, check storage/logs/payload.json
  • Same for a GitHub or Docker Hub request

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to Refactor Phabricator event and last payload save code.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2015, 19:54
This revision was automatically updated to reflect the committed changes.