PSR-1 compatible tests
ClosedPublic
Actions

Authored by dereckson on Dec 31 2015, 18:58.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIFc624f02dffce: PSR-1 compatible tests

Summary

PHP Tests are now put in Nasqueron\Notifications\Tests namespace.

This allows to full PSR-1 compatibility both for app/ and tests/ directories.

Test Plan

Run phpunit.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 331.Dec 31 2015, 18:58

dereckson retitled this revision from to PSR-1 compatible tests.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Dec 31 2015, 18:59

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added projects: Notifications center, Continous integration and delivery.

dereckson edited edge metadata.

This revision is now accepted and ready to land.Dec 31 2015, 18:59

Closed by commit rNOTIFc624f02dffce: PSR-1 compatible tests (authored by dereckson, committed by dereckson). · Explain WhyDec 31 2015, 19:01

This revision was automatically updated to reflect the committed changes.

The goal of this change is to be able to run a minimalist phpcs --standard=PSR1 run.

In a coming change, we'll call phpcs from a Jenkins job using this target:

<target name="phpcs"
        unless="phpcs.done"
        description="Find coding standard violations using PHP_CodeSniffer and print human readable output. Intended for usage on the command line before committing.">
 <exec executable="${phpcs}" taskname="phpcs">
  <arg value="--standard=PSR1" />
  <arg value="--extensions=php" />
  <arg value="--ignore=autoload.php" />
  <arg path="${basedir}/app" />
  <arg path="${basedir}/tests" />
 </exec>

 <property name="phpcs.done" value="true"/>
</target>