Refactor ActionsReport events listener
ClosedPublic
Actions

Authored by dereckson on Jan 8 2016, 14:13.

Details

Reviewers

Commits

Unknown Object (Diffusion Commit)
rNOTIF6ed92b9a75b8: Refactor ActionsReport events listener

Summary

We now define the listener for report events in the service provider,
to tie up with the application without any facade, and use dependencies
injection.

This change furthermore removes the need of a PHPMD ignore rule.

Test Plan

Send a payload.
Run D176 tests.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 418.Jan 8 2016, 14:13

dereckson retitled this revision from to Refactor ActionsReport events listener.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

PHPMD is happy.

$ ant phpmd
Buildfile: /home/ubuntu/workspace/notifications/build.xml

phpmd:
    [phpmd] 

BUILD SUCCESSFUL
Total time: 4 seconds
``` ant phpmd
Buildfile: /home/ubuntu/workspace/notifications/build.xml

phpmd:
    [phpmd] 

BUILD SUCCESSFUL
Total time: 4 seconds