Differential D263

Tests for GitHubGateController
ClosedPublic
Actions

Authored by dereckson on Jan 24 2016, 10:27.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIFeb3120dd2c9e: Tests for GitHubGateController

Summary

rNOTIF920690128405 added a isValidRequest method to the class,
and amended onPost and isLegitRequest methods.

We provide tests to cover the new not legit case, and the invalid
cases not provided in test shipped with the former revision.

Test Plan

Run tests and assert we have a full class coverage

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 613.Jan 24 2016, 10:27

dereckson retitled this revision from to Tests for GitHubGateController.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

Build started: https://ci.nasqueron.org/job/test-notifications-phab/54/ (console: https://ci.nasqueron.org/job/test-notifications-phab/54/console)

dereckson accepted this revision.Jan 24 2016, 10:27

dereckson added a reviewer: dereckson.

This revision is now accepted and ready to land.Jan 24 2016, 10:27

Build is green https://ci.nasqueron.org/job/test-notifications-phab/54/ for more details.

Closed by commit rNOTIFeb3120dd2c9e: Tests for GitHubGateController (authored by dereckson, committed by dereckson). · Explain WhyJan 24 2016, 10:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tests/

Http/

Controllers/

GitHubGateControllerTest.php

38 lines

Diff 614

View Options

tests/Http/Controllers/GitHubGateControllerTest.php

Tests for GitHubGateControllerClosedPublicActions