Refactoring: split css_for_project and css_for_score
ClosedPublic
Actions

Authored by dereckson on Jul 10 2016, 21:31.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 12:52

	Unknown Object (File)
	Mon, Nov 11, 04:01

	Unknown Object (File)
	Sun, Nov 10, 01:01

	Unknown Object (File)
	Sat, Nov 9, 05:36

	Unknown Object (File)
	Sat, Nov 9, 05:35

	Unknown Object (File)
	Sat, Nov 9, 05:17

	Unknown Object (File)
	Tue, Oct 22, 08:40

	Unknown Object (File)
	Oct 15 2024, 22:21

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T912: Follow the community Ruby Style Guide

Commits

rTOMMYc6d4f9fc5f1a: Refactoring: split css_for_project and css_for_score

Summary

Reduce cyclomatic complexity and length of css_for_project by
extracting the green CSS class selection into a separate method.

Test Plan

Run the app, see CSS styles stay the same

Diff Detail

Repository

rTOMMY Tommy

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1170.Jul 10 2016, 21:31

dereckson retitled this revision from to Refactoring: split css_for_project and css_for_score.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jul 10 2016, 21:32

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 10 2016, 21:32

Closed by commit rTOMMYc6d4f9fc5f1a: Refactoring: split css_for_project and css_for_score (authored by dereckson, committed by dereckson). · Explain WhyJul 10 2016, 21:32

This revision was automatically updated to reflect the committed changes.

dereckson added a task: T912: Follow the community Ruby Style Guide.Jul 11 2016, 14:15

Revision Contents
Changeset List

Path

Size

tommy.rb

27 lines

Diff 1171

View Options

Refactoring: split css_for_project and css_for_scoreClosedPublicActions