Paths

Table of Contentst

Allow to determine if a node has a role
ClosedPublic
Actions

Authored by dereckson on Nov 1 2017, 18:59.

Tags

None

Referenced Files

	F12486163: D1146.diff
	Sat, Nov 8, 01:28

	F12484093: D1146.diff
	Fri, Nov 7, 23:46

	F12482716: D1146.id.diff
	Fri, Nov 7, 22:25

	F12472680: D1146.diff
	Fri, Nov 7, 15:05

	F12469779: D1146.id2929.diff
	Fri, Nov 7, 13:21

	F12459788: D1146.id2928.diff
	Fri, Nov 7, 04:47

	F12458068: D1146.diff
	Fri, Nov 7, 03:39

	Unknown Object (File)
	Thu, Nov 6, 20:41

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1275: Deploy zemke-rhyne to Ysul

Commits

rOPS2fa163400442: Allow to determine if a node has a role

Summary

Ref T1275

Test Plan

salt * node.has_role devserver

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

master

Build Status

Buildable 1805
Build 2053: arc lint + arc unit

Event Timeline

dereckson created this revision.Nov 1 2017, 18:59

dereckson planned changes to this revision.Nov 1 2017, 19:02

dereckson added inline comments.

_modules/node.py
85	'node' virtual returned False: name 'Node' is not defined

s/Node/None

Harbormaster completed remote builds in B1806: Diff 2928.Nov 1 2017, 19:39

If we return something that would be better

Harbormaster completed remote builds in B1807: Diff 2929.Nov 1 2017, 20:29

$ pm go ops
$ arc patch D1146
$ salt-call --local node.has_role devserver
local:
    True
$ salt-call --local node.has_role devserverz
local:
    False

This revision is now accepted and ready to land.Nov 1 2017, 21:40

Closed by commit rOPS2fa163400442: Allow to determine if a node has a role (authored by dereckson). · Explain WhyNov 1 2017, 21:41

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

_modules/

node.py

13 lines

Diff 2927

View Options

Allow to determine if a node has a roleClosedPublicActions