Page MenuHomeDevCentral

Add shellcheck linter
ClosedPublic

Authored by dereckson on Nov 3 2017, 18:24.
Referenced Files
F11752179: D1163.id2974.diff
Sat, Sep 20, 09:58
F11751497: D1163.diff
Sat, Sep 20, 07:40
F11746371: D1163.diff
Fri, Sep 19, 15:28
Unknown Object (File)
Tue, Sep 16, 09:25
Unknown Object (File)
Sun, Sep 14, 15:06
Unknown Object (File)
Sat, Sep 13, 17:44
Unknown Object (File)
Tue, Sep 9, 23:40
Unknown Object (File)
Mon, Sep 8, 01:19

Details

Summary

Setup similar to rOPSf637b1b858173

Test Plan

arc lint

Diff Detail

Repository
rDARC nasqueron/arcanist Docker image
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
shellcheck (branched from master)
Build Status
Buildable 1829
Build 2077: arc lint + arc unit

Event Timeline

Works fine:

$ cat > foo.sh
#!/bin/sh

foo $1
$ git add foo.sh 
$ arc lint
>>> Lint for foo.sh:


   Advice  (SC2086) SHELLCHECK
    Double quote to prevent globbing and word splitting.

               1 #!/bin/sh
               2 
    >>>        3 foo $1
                     ^
 OKAY  No lint warnings.
This revision is now accepted and ready to land.Nov 3 2017, 18:30
This revision was automatically updated to reflect the committed changes.