Page MenuHomeDevCentral

Add phpcs in Composer
ClosedPublic

Authored by dereckson on Dec 31 2015, 19:19.
Tags
None
Referenced Files
F28414793: D139.diff
Tue, May 12, 05:46
F28366480: D139.id334.diff
Mon, May 11, 20:00
F28366386: D139.id334.diff
Mon, May 11, 19:55
F28347881: D139.diff
Mon, May 11, 16:09
F28347880: D139.id334.diff
Mon, May 11, 16:09
Unknown Object (File)
Mon, May 11, 00:13
Unknown Object (File)
Sun, May 10, 22:53
Unknown Object (File)
Sun, May 10, 12:22
Subscribers
None

Details

Reviewers
dereckson
Commits
Unknown Object (Diffusion Commit)
rNOTIFd3c9caa36831: Add phpcs in Composer
Summary

We're going to add a phpcs check in Arcanist and have
already implemented it in the Jenkins tests job.

So, it makes sense to add it as a dev dependency in Composer.

Test Plan

Ensure Composer is valid JSON.

jsonlint composer.json

Update composer dependencies, then check phpcs binary exists.

composer update
ls -lh vendor/bin/phpcs

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
jenkins
Build Status
Buildable 174
Build 174: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Add phpcs in Composer.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2015, 19:20
This revision was automatically updated to reflect the committed changes.