Differential D1536

Enforce opening brace on same line than class declaration
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 21:08.

Tags

None

Referenced Files

	F26743314: D1536.diff
	Sat, Apr 25, 20:17

	F26699598: D1536.id3921.diff
	Sat, Apr 25, 04:33

	F26680526: D1536.diff
	Fri, Apr 24, 22:44

	Unknown Object (File)
	Fri, Apr 24, 17:50

	Unknown Object (File)
	Thu, Apr 23, 09:20

	Unknown Object (File)
	Thu, Apr 23, 09:10

	Unknown Object (File)
	Wed, Apr 22, 09:28

	Unknown Object (File)
	Tue, Apr 21, 14:32

Subscribers

None

Details

Reviewers

Commits

rNOTIF85fc0f62b8e1: Enforce opening brace on same line than class declaration

Summary

Currently, Laravel files were sometimes left untouched.

Even if generated by Laravel, it seems better to apply Nasqueron
code style to those files too.

Test Plan

no op

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

upgrade-phan

Build Status

Buildable 2409
Build 2657: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	Unknown Unit Message ("") sh: phpunit: command not found
	0 ms	Unknown Unit Message ("") sh: phpunit: command not found
	0 ms	Unknown Unit Message ("") sh: phpunit: command not found
	0 ms	Unknown Unit Message ("") sh: phpunit: command not found
	0 ms	Unknown Unit Message ("") sh: phpunit: command not found
		View Full Test Results (6 Broken)

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 21:08

dereckson created this revision.

Harbormaster failed remote builds in B2409: Diff 3919!Mar 29 2018, 21:08

Mixed with a composer version upgrade

dereckson edited the summary of this revision. (Show Details)Mar 29 2018, 21:10

dereckson edited the test plan for this revision. (Show Details)

Restrict change to only the style fix

Harbormaster completed remote builds in B2410: Diff 3920.Mar 29 2018, 21:13

dereckson accepted this revision.Mar 29 2018, 21:13

This revision is now accepted and ready to land.Mar 29 2018, 21:13

Closed by commit rNOTIF85fc0f62b8e1: Enforce opening brace on same line than class declaration (authored by dereckson). · Explain WhyMar 29 2018, 21:15

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Console/

Commands/

4 lines

4 lines

Http/

Controllers/

4 lines

4 lines

Middleware/

EncryptCookies.php

4 lines

VerifyCsrfToken.php

4 lines

Requests/

4 lines

Jobs/

4 lines

Providers/

AppServiceProvider.php

4 lines

PhabricatorAPIServiceProvider.php

4 lines

PhabricatorProjectsMapServiceProvider.php

4 lines

RouteServiceProvider.php

4 lines

SentryServiceProvider.php

4 lines

2 lines

Diff 3919

app/Console/Commands/ConfigShow.php

Loading...

app/Console/Kernel.php

Loading...

app/Http/Controllers/Controller.php

Loading...

app/Http/Kernel.php

Loading...

app/Http/Middleware/EncryptCookies.php

Loading...

app/Http/Middleware/VerifyCsrfToken.php

Loading...

app/Http/Requests/Request.php

Loading...

app/Jobs/Job.php

Loading...

app/Providers/AppServiceProvider.php

Loading...

app/Providers/PhabricatorAPIServiceProvider.php

Loading...

app/Providers/PhabricatorProjectsMapServiceProvider.php

Loading...

app/Providers/RouteServiceProvider.php

Loading...

app/Providers/SentryServiceProvider.php

Loading...

composer.json

Loading...