Paths

Table of Contentst

Avoid both assignment and comparison in same time
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 21:34.

Tags

None

Referenced Files

	F24798284: D1538.id.diff
	Wed, Mar 11, 05:28

	F24791208: D1538.diff
	Tue, Mar 10, 22:13

	F24785498: D1538.id3927.diff
	Tue, Mar 10, 14:23

	Unknown Object (File)
	Mon, Mar 9, 22:21

	Unknown Object (File)
	Sun, Mar 8, 14:16

	Unknown Object (File)
	Sun, Mar 8, 08:25

	Unknown Object (File)
	Sun, Mar 8, 00:15

	Unknown Object (File)
	Fri, Mar 6, 19:55

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rNOTIF0575d2497ed6: Avoid both assignment and comparison in same time

Test Plan

phpcs with Generic.CodeAnalysis.AssignmentInCondition rule

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

no-assignment-within-condition

Build Status

Buildable 2412
Build 2660: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	Unknown Unit Message ("")

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 21:34

dereckson created this revision.

Harbormaster failed remote builds in B2412: Diff 3924!Mar 29 2018, 21:34

Not so no op

Rebase

Harbormaster completed remote builds in B2414: Diff 3927.Mar 29 2018, 21:55

dereckson accepted this revision.Mar 29 2018, 21:55

This revision is now accepted and ready to land.Mar 29 2018, 21:55

Closed by commit rNOTIF0575d2497ed6: Avoid both assignment and comparison in same time (authored by dereckson). · Explain WhyMar 29 2018, 21:56

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

GitHub/

Events/

RepositoryEvent.php

3 lines

Diff 3924

View Options

app/Analyzers/GitHub/Events/RepositoryEvent.php

Avoid both assignment and comparison in same timeClosedPublicActions