Differential D1654

Deploy for dereckson a playlist generator script on devserver
ClosedPublic
Actions

Authored by dereckson on Jul 21 2018, 15:21.

Tags

None

Referenced Files

	F28055348: D1654.id4224.diff
	Sat, May 9, 19:29

	F28046480: D1654.id4225.diff
	Sat, May 9, 18:20

	F28027921: D1654.id4227.diff
	Sat, May 9, 15:58

	F27943323: D1654.id4226.diff
	Sat, May 9, 05:37

	Unknown Object (File)
	Fri, May 8, 18:45

	Unknown Object (File)
	Thu, May 7, 11:03

	Unknown Object (File)
	Thu, May 7, 11:02

	Unknown Object (File)
	Thu, May 7, 11:02

Subscribers

None

Details

Reviewers

Commits

rOPS1efecd488fcb: Deploy for dereckson a playlist generator script on devserver

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

http2pls

Build Status

Buildable 2598
Build 2846: arc lint + arc unit

Event Timeline

dereckson created this revision.Jul 21 2018, 15:21

Harbormaster completed remote builds in B2597: Diff 4224.Jul 21 2018, 15:27

dereckson requested review of this revision.Jul 21 2018, 15:27

dereckson planned changes to this revision.Jul 21 2018, 15:50

dereckson added inline comments.

roles/devserver/userland-home/files/dereckson/bin/http2pls
45	If the URL isn't valid, the urlopen function will raise the following exception: ValueError: unknown url type: 'fdfdf' File "/usr/local/lib/python3.6/urllib/request.py", line 384, in _parse raise ValueError("unknown url type: %r" % self.full_url) So a try block could handle URL errors here.
50	two \n

PEP-8 compliant

Harbormaster completed remote builds in B2598: Diff 4225.Jul 22 2018, 12:47

Handle URL errors

Harbormaster completed remote builds in B2599: Diff 4226.Jul 22 2018, 12:58

dereckson accepted this revision.Jul 22 2018, 13:03

dereckson marked an inline comment as done.

This revision is now accepted and ready to land.Jul 22 2018, 13:03

Closed by commit rOPS1efecd488fcb: Deploy for dereckson a playlist generator script on devserver (authored by dereckson). · Explain WhyJul 22 2018, 13:06

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

devserver/

userland-home/

files/

dereckson/

bin/

60 lines

userland-software/

4 lines

Diff 4225

roles/devserver/userland-home/files/dereckson/bin/http2pls

Loading...

roles/devserver/userland-software/dev.sls

Loading...