Differential D2072

Prune packages also defined in core roles
ClosedPublic
Actions

Authored by dereckson on Jul 5 2019, 18:03.

Tags

None

Referenced Files

	F10152674: D2072.diff
	Fri, Jun 20, 19:03

	Unknown Object (File)
	Thu, Jun 19, 04:33

	Unknown Object (File)
	Wed, Jun 18, 19:21

	Unknown Object (File)
	Wed, Jun 18, 18:33

	Unknown Object (File)
	Tue, Jun 17, 06:15

	Unknown Object (File)
	Tue, Jun 17, 00:53

	Unknown Object (File)
	Sun, Jun 15, 02:41

	Unknown Object (File)
	Fri, Jun 13, 17:04

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rOPS60e14cc6f1f7: Prune packages also defined in core roles

Summary

The core/userland-software unit is always installed.

As such, any package defined there isn't needed in shellserver role.

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

prune-duplicate-packages (branched from master)

Build Status

Buildable 3228
Build 3477: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jul 5 2019, 18:03

dereckson created this revision.

Harbormaster completed remote builds in B3228: Diff 5226.Jul 5 2019, 18:03

I wanted a test to detect the case, but it's not trivial, as we currently don't have a sls renderer.

dereckson accepted this revision.Jul 5 2019, 18:03

This revision is now accepted and ready to land.Jul 5 2019, 18:03

Closed by commit rOPS60e14cc6f1f7: Prune packages also defined in core roles (authored by dereckson). · Explain WhyJul 5 2019, 18:03

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

shellserver/

userland-software/

base.sls

3 lines

Diff 5226

View Options

roles/shellserver/userland-software/base.sls

Prune packages also defined in core rolesClosedPublicActions