Page MenuHomeDevCentral

Address File and CodeFile inheritance issues
ClosedPublic

Authored by dereckson on Jan 28 2020, 08:53.
Tags
None
Referenced Files
F10150615: D2162.diff
Fri, Jun 20, 16:01
F10145781: D2162.diff
Fri, Jun 20, 09:12
Unknown Object (File)
Tue, Jun 17, 07:31
Unknown Object (File)
Sun, Jun 15, 17:14
Unknown Object (File)
Sat, Jun 14, 09:48
Unknown Object (File)
Sat, Jun 14, 09:48
Unknown Object (File)
Fri, Jun 13, 18:35
Unknown Object (File)
Fri, Jun 13, 18:26
Subscribers
None

Details

Summary

The File class also implemented include logic.

Actually, this code was the one used when object was instancied by
CodeFile::From(), as it returned a File and not a CodeFile instance.

That first issue masked another one, CodeFile included the file
by name, and not by full path.

Test Plan

Run tests

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Jan 28 2020, 08:54
This revision was landed with ongoing or failed builds.Jan 28 2020, 08:54
This revision was automatically updated to reflect the committed changes.