Differential D2164

Document File::from return value as static
ClosedPublic
Actions

Authored by dereckson on Jan 29 2020, 03:10.

Tags

None

Referenced Files

	F10143806: D2164.diff
	Fri, Jun 20, 06:10

	Unknown Object (File)
	Tue, Jun 17, 14:35

	Unknown Object (File)
	Fri, Jun 13, 18:29

	Unknown Object (File)
	Thu, Jun 12, 03:54

	Unknown Object (File)
	Wed, Jun 11, 22:01

	Unknown Object (File)
	Wed, Jun 11, 14:46

	Unknown Object (File)
	Wed, Jun 11, 04:24

	Unknown Object (File)
	Wed, Jun 11, 00:53

Subscribers

None

Details

Reviewers

Commits

rKOT42911b95f98d: Document File::from return value as static

Summary

This change allows Phan to correctly analyze the methods availability.

This is a follow-up for 7266cfd77f31.

Test Plan

Without the change, Phan outputs:

$ phan
src/Registration/PSR4/Autoloader.php:51 PhanUndeclaredMethod Call to undeclared method \Keruald\OmniTools\IO\File::tryInclude
tests/Reflection/CodeFileTest.php:41 PhanUndeclaredMethod Call to undeclared method \Keruald\OmniTools\IO\File::canBeIncluded

After the change, it doesn't prints these messages.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Jan 29 2020, 03:10

dereckson created this revision.

Harbormaster completed remote builds in B3365: Diff 5453.Jan 29 2020, 03:10

dereckson accepted this revision.Jan 29 2020, 03:11

This revision is now accepted and ready to land.Jan 29 2020, 03:11

This revision was landed with ongoing or failed builds.Jan 29 2020, 03:11

Closed by commit rKOT42911b95f98d: Document File::from return value as static (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT42911b95f98d: Document File::from return value as static.

Revision Contents
Changeset List

Path

Size

src/

IO/

3 lines

Diff 5454

src/IO/File.php

Loading...