Page MenuHomeDevCentral
Differential D2481

Ensure array key exists The service entry point can be used outside a web context, for example through CLI to run a MediaWiki maintenance script. As such, we can't make assertions on keys available in the $_SERVER array.
ClosedPublic
Actions

Authored by dereckson on Jan 23 2022, 17:00.
Tags
None
Referenced Files
F22603027: D2481.diff
Thu, Jan 29, 20:59
F22490047: D2481.diff
Thu, Jan 29, 00:05
F22475666: D2481.id.diff
Wed, Jan 28, 21:48
Unknown Object (File)
Wed, Jan 28, 02:06
Unknown Object (File)
Sat, Jan 24, 21:37
Unknown Object (File)
Fri, Jan 23, 23:59
Unknown Object (File)
Fri, Jan 23, 19:31
Unknown Object (File)
Fri, Jan 23, 13:26
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1675: Fix deprecation introduced by PHP 7.4 and PHP 8
Commits
rSAASSVC223248b07ad9: Ensure array key exists
Summary

Ref T1675

Test Plan

sudo -u mediawiki mw update agora

Diff Detail

Repository
rSAASSVC SaaS base entry point
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
master
Build Status
Buildable 3868
Build 4119: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jan 23 2022, 17:00
dereckson created this revision.
Harbormaster completed remote builds in B3868: Diff 6254.Jan 23 2022, 17:00
dereckson accepted this revision.Jan 23 2022, 17:00
This revision is now accepted and ready to land.Jan 23 2022, 17:00
Closed by commit rSAASSVC223248b07ad9: Ensure array key exists (authored by dereckson). · Explain WhyJan 23 2022, 17:02
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rSAASSVC223248b07ad9: Ensure array key exists.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 6254

View Options

src/Service.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator