Page MenuHomeDevCentral
Differential D2494

Don't allow to construct a File with a null path
ClosedPublic
Actions

Authored by dereckson on Jan 29 2022, 20:25.
Tags
None
Referenced Files
F21144136: D2494.diff
Sun, Jan 18, 06:47
Unknown Object (File)
Thu, Jan 15, 20:27
Unknown Object (File)
Thu, Jan 15, 19:06
Unknown Object (File)
Thu, Jan 15, 18:13
Unknown Object (File)
Wed, Jan 14, 00:50
Unknown Object (File)
Tue, Jan 13, 17:27
Unknown Object (File)
Tue, Jan 13, 06:37
Unknown Object (File)
Tue, Jan 13, 06:36
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rKOTf1b282e7562c: Don't allow to construct a File with a null path

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Passed
Unit
Test Failures
Branch
arcpatch-D2494
Build Status
Buildable 3888
Build 4139: arc lint + arc unit

Unit TestsBroken
View All

TimeTest
0 ms/home/dereckson/dev/nasqueron/keruald/omnitools/tests/IO/FileTest.php

Event Timeline

dereckson requested review of this revision.Jan 29 2022, 20:25
dereckson created this revision.
Harbormaster completed remote builds in B3885: Diff 6283.Jan 29 2022, 20:25
dereckson updated this revision to Diff 6287.Feb 1 2022, 03:02

Add test

Harbormaster completed remote builds in B3888: Diff 6287.Feb 1 2022, 03:02
dereckson accepted this revision.Feb 1 2022, 03:03
$ phpunit tests/IO/FileTest.php                                                                                                              (git)-[arcpatch-D2494] 

PHPUnit 9.5.13 by Sebastian Bergmann and contributors.

......................                                            22 / 22 (100%)

Time: 00:00.002, Memory: 18.00 MB

OK (22 tests, 22 assertions)
This revision is now accepted and ready to land.Feb 1 2022, 03:03
This revision was landed with ongoing or failed builds.Feb 1 2022, 03:04
Closed by commit rKOTf1b282e7562c: Don't allow to construct a File with a null path (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rKOTf1b282e7562c: Don't allow to construct a File with a null path.

Revision Contents
Changeset List

PathSize
src/
IO/
2 lines
tests/
IO/
15 lines

Diff 6287

View Options

src/IO/File.php

Loading...
View Options

tests/IO/FileTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator