Normally, /etc/os-release should be regenerated at boot time.
If we don't boot after a userland update, the file won't be updated either.
Raise a warning if the file is not up-to-date, a critical error if it doesn't exist.
Ref T2007.
Details
Details
Tested on WindRiver
Diff Detail
Diff Detail
- Repository
- rOPS Nasqueron Operations
- Lint
Lint Passed Severity Location Code Message Advice roles/core/monitoring/files/checks/nrpe/os_family/FreeBSD/check-os-release.sh:15 SC1091 SHELLCHECK - Unit
No Test Coverage - Branch
- check-os-release
- Build Status
Buildable 5439 Build 5720: arc lint + arc unit
Event Timeline
Comment Actions
Hi,
Should the shellcheck suggestion be added? I was not certain, If not, the code looks good :)
Comment Actions
The -x option allows shellcheck to source the external files (here /var/run/os-release), so it can know $VERSION exists for example:
$ shellcheck -x roles/core/monitoring/files/checks/nrpe/os_family/FreeBSD/check-os-release.sh $ echo $? 0