Differential D3429

Prevent globbing and word splitting for shell script name
ClosedPublic
Actions

Authored by dereckson on Sep 6 2024, 21:38.

Tags

None

Referenced Files

	F12535306: D3429.diff
	Mon, Nov 10, 02:58

	Unknown Object (File)
	Sat, Nov 8, 08:08

	Unknown Object (File)
	Sat, Nov 8, 01:08

	Unknown Object (File)
	Fri, Nov 7, 20:26

	Unknown Object (File)
	Fri, Nov 7, 12:19

	Unknown Object (File)
	Fri, Nov 7, 08:20

	Unknown Object (File)
	Tue, Nov 4, 02:54

	Unknown Object (File)
	Sun, Nov 2, 20:39

Subscribers

None

Details

Reviewers

Commits

rSNIPPETS9af6d1f347c9: Prevent globbing and word splitting for shell script name

Summary

Shellcheck highlights an issue with the shell script snippet:

In roles/core/certificates/files/delete-certbot-certificate.sh line 28:
    echo "Usage: $(basename $0) <certificate>" >&2
                            ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    echo "Usage: $(basename "$0") <certificate>" >&2

Test Plan

Tested with new script in rOPS

Diff Detail

Repository

rSNIPPETS Snippets

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-basename

Build Status

Buildable 5464
Build 5745: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 6 2024, 21:38

dereckson created this revision.

Harbormaster completed remote builds in B5464: Diff 8850.Sep 6 2024, 21:38

dereckson accepted this revision.Sep 6 2024, 21:38

This revision is now accepted and ready to land.Sep 6 2024, 21:38

Closed by commit rSNIPPETS9af6d1f347c9: Prevent globbing and word splitting for shell script name (authored by dereckson). · Explain WhySep 6 2024, 21:38

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rSNIPPETS9af6d1f347c9: Prevent globbing and word splitting for shell script name.

Revision Contents
Changeset List

Path

Size

shell/

2 lines

Diff 8850

shell/script.sh

Loading...