Differential D3827

Modernize ApplicationConfiguration
ClosedPublic
Actions

Authored by dereckson on Wed, Oct 29, 22:59.

Details

Reviewers

dereckson

Commits

rOBSIDIAN330f740251a9: Modernize ApplicationConfiguration

Summary

Add types to properties

Add property $name explicitly

This fixes the following issue:
PHP Deprecated:
Creation of dynamic property ApplicationConfiguration::$name is deprecated
in /var/51-wwwroot/obsidian/workspaces/src/Engines/Apps/ApplicationConfiguration.php on line 66

Following style conventions for class end

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Wed, Oct 29, 22:59

dereckson created this revision.

Harbormaster completed remote builds in B6116: Diff 9911.Wed, Oct 29, 22:59

dereckson accepted this revision.Wed, Oct 29, 22:59

This revision is now accepted and ready to land.Wed, Oct 29, 22:59

Closed by commit rOBSIDIAN330f740251a9: Modernize ApplicationConfiguration (authored by dereckson). · Explain WhyWed, Oct 29, 23:00

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIAN330f740251a9: Modernize ApplicationConfiguration.

Revision Contents
Changeset List

Path

Size

workspaces/

src/

Engines/

Apps/

ApplicationConfiguration.php

24 lines

Diff 9912

View Options

workspaces/src/Engines/Apps/ApplicationConfiguration.php

Modernize ApplicationConfigurationClosedPublicActions