Differential D3848

Remove features implemented in PHP 8
ClosedPublic
Actions

Authored by dereckson on Wed, Nov 5, 22:21.

Details

Reviewers

dereckson

Commits

rKOTe2d6dafbace7: Remove features implemented in PHP 8
rKERUALDfd7258079ca5: Remove features implemented in PHP 8

Summary

Several traversable and string functions have been directly added to PHP 8.

In every case, the OmniTools static function call can be swapped as is
to a PHP 8 call, without any change in argument order.

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Test Failures

Branch

php7-cleanup

Build Status

Buildable 6147
Build 6431: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/tests/Collections/TraversableUtilitiesTest.php
	0 ms	/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/tests/Strings/Multibyte/StringUtilitiesTest.php

Event Timeline

dereckson requested review of this revision.Wed, Nov 5, 22:21

dereckson created this revision.

Harbormaster completed remote builds in B6147: Diff 9965.Wed, Nov 5, 22:21

Running tests from repository mono-root, not lib-root

Harbormaster completed remote builds in B6148: Diff 9966.Wed, Nov 5, 22:22

Rebase agaisnt origin/develop/omnitools-1.x

Harbormaster completed remote builds in B6149: Diff 9967.Wed, Nov 5, 22:23

dereckson accepted this revision.Wed, Nov 5, 22:24

This revision is now accepted and ready to land.Wed, Nov 5, 22:24

Closed by commit rKERUALDfd7258079ca5: Remove features implemented in PHP 8 (authored by dereckson). · Explain WhyWed, Nov 5, 22:25

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALDfd7258079ca5: Remove features implemented in PHP 8.

dereckson added a commit: rKOTe2d6dafbace7: Remove features implemented in PHP 8.Wed, Nov 5, 23:26

Revision Contents
Changeset List

Path

Size

omnitools/

src/

Collections/

TraversableUtilities.php

16 lines

HTTP/

Requests/

WithURL.php

2 lines

Strings/

Multibyte/

StringUtilities.php

23 lines

tests/

Collections/

TraversableUtilitiesTest.php

16 lines

Strings/

Multibyte/

StringUtilitiesTest.php

17 lines

Diff 9965

View Options

omnitools/src/Collections/TraversableUtilities.php

View Options

omnitools/src/HTTP/Requests/WithURL.php

View Options

omnitools/src/Strings/Multibyte/StringUtilities.php

View Options

omnitools/tests/Collections/TraversableUtilitiesTest.php

View Options

omnitools/tests/Strings/Multibyte/StringUtilitiesTest.php

Remove features implemented in PHP 8ClosedPublicActions

Details

Diff Detail

Unit TestsBrokenView All

Event Timeline

Revision ContentsChangeset List

Diff 9965

omnitools/src/Collections/TraversableUtilities.php

omnitools/src/HTTP/Requests/WithURL.php

omnitools/src/Strings/Multibyte/StringUtilities.php

omnitools/tests/Collections/TraversableUtilitiesTest.php

omnitools/tests/Strings/Multibyte/StringUtilitiesTest.php

Remove features implemented in PHP 8
ClosedPublic
Actions

Unit TestsBroken
View All

Revision Contents
Changeset List