Page MenuHomeDevCentral
Differential D4046

Normalize quotes
Needs ReviewPublic
Actions

Authored by dereckson on Fri, Apr 3, 22:50.
Tags
None
Referenced Files
F25201016: D4046.id10562.diff
Sat, Apr 4, 19:41
F25199298: D4046.id10562.largetrue.diff
Sat, Apr 4, 16:40
F25197131: D4046.id10562.diff
Sat, Apr 4, 12:37
F25197112: D4046.largetrue.diff
Sat, Apr 4, 12:35
F25194150: D4046.diff
Sat, Apr 4, 09:28
F25194024: D4046.diff
Sat, Apr 4, 09:21
Subscribers
None

Details

Reviewers
philectro
Summary

A lot of Jinja, Python and Salt expressions uses single quotes.

As other language code conventions tend to switch to double quotes,
it's a good move to respect principle of less surprise and to be coherent
to use double quotes in this repository too.

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Errors
SeverityLocationCodeMessage
Errorroles/viperserv/eggdrop/cron.sls:16E111flake8 E111
Errorroles/viperserv/eggdrop/cron.sls:19E111flake8 E111
Errorroles/viperserv/eggdrop/cron.sls:55E501flake8 E501
Unit
No Test Coverage
Branch
normalize-quotes
Build Status
Buildable 6570
Build 6854: arc lint + arc unit

Event Timeline

dereckson created this revision.Fri, Apr 3, 22:50
Herald added a reviewer: philectro. · View Herald TranscriptFri, Apr 3, 22:50

This change touches Wolfplex files. As such, administrative approval is needed from Wolfplex technical contact.

dereckson requested review of this revision.Fri, Apr 3, 22:50
Harbormaster completed remote builds in B6570: Diff 10562.Fri, Apr 3, 22:50

Revision Contents
Changeset List

PathSize
_modules/
2 lines
hotfixes/
4 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
426 lines
pillar/
credentials/
2 lines
roles/
bastion/
pam/
2 lines
sshd-otp/
4 lines
2 lines
yubico/
6 lines
2 lines
2 lines
core/
certificates/
2 lines
hostname/
4 lines
login/
6 lines
memory/
2 lines
motd/
12 lines
network/
files/
ipv6-tunnels/
2 lines
4 lines
10 lines
6 lines
22 lines
4 lines
6 lines
20 lines
4 lines
rc/
6 lines
rsyslog/
2 lines
salt/
8 lines
src/
4 lines
sshd/
files/
2 lines
4 lines
storage/
2 lines
sudo/
2 lines
sysctl/
6 lines
timezone/
6 lines
userland-home/
6 lines
userland-software/
14 lines
12 lines
6 lines
users/
26 lines
dbserver-mysql/
content/
4 lines
mysql-server/
8 lines
6 lines
dbserver-pgsql/
server/
4 lines
2 lines
devserver/
api-exec/
2 lines
datacube/
2 lines
mail/
2 lines
pkg/
2 lines
userland-home/
18 lines
10 lines
userland-software/
2 lines
files/
2 lines
6 lines
20 lines
10 lines
2 lines
12 lines
webserver-wwwroot51/
20 lines
dns/
knot/
2 lines
freebsd-repo/
4 lines
grafana/
grafana/
2 lines
mailserver/
dkim/
2 lines
dovecot/
2 lines
2 lines
28 lines
vimbadmin/
2 lines
opensearch/
dashboards/
6 lines
2 lines
opensearch/
10 lines
files/
8 lines
8 lines
14 lines
2 lines
10 lines
2 lines
14 lines
8 lines
paas-docker/
containers/
12 lines
12 lines
6 lines
6 lines
14 lines
16 lines
12 lines
20 lines
8 lines
10 lines
20 lines
files/
_tomcat/
2 lines
8 lines
10 lines
2 lines
14 lines
16 lines
10 lines
2 lines
10 lines
12 lines
28 lines
16 lines
8 lines
2 lines
2 lines
34 lines
6 lines
34 lines
22 lines
16 lines
10 lines
6 lines
8 lines
10 lines
2 lines
6 lines
8 lines
12 lines
docker/
4 lines
2 lines
2 lines
2 lines
2 lines
kernel/
4 lines
monitoring/
4 lines
nginx/
16 lines
files/
vhosts/
4 lines
2 lines
16 lines
2 lines
2 lines
2 lines
2 lines
2 lines
systemd-unit/
4 lines
wrappers/
8 lines
wwwroot-502/
2 lines
wwwroot-content/
4 lines
2 lines
paas-jails/
jails/
6 lines
paas-lxc/
lxc/
2 lines
prometheus/
prometheus/
2 lines
redis/
server/
2 lines
router/
carp/
files/
4 lines
4 lines
saas-mediawiki/
data/
2 lines
mediawiki/
2 lines
2 lines
4 lines
nginx/
2 lines
software/
6 lines
salt-primary/
account/
2 lines
service/
2 lines
shellserver/
odderon/
2 lines
quassel-core/
2 lines
16 lines
2 lines
userland-software/
30 lines
6 lines
vault/
4 lines
vhosts/
2 lines
web-hosting/
4 lines
vault/
policies/
6 lines
vault/
6 lines
viperserv/
account/
12 lines
eggdrop/
34 lines
8 lines
10 lines
2 lines
fantoir/
6 lines
rabbitmq-tcl/
2 lines
wikidata-access-layer/
2 lines
webserver-alkane/
account/
16 lines
alkane/
2 lines
directories/
4 lines
php/
10 lines
files/
2 lines
36 lines
4 lines
8 lines
webserver-content/
org/
eglide/
2 lines
nasqueron/
2 lines
wolfplex/
2 lines
space/
hypership/
2 lines
webserver-core/
nginx/
2 lines
webserver-legacy/
jenkins-cd/
2 lines
php-sites/
10 lines
files/
2 lines
26 lines
6 lines
static-sites/
4 lines
tweaks/
2 lines

Diff 10562

View Options

_modules/paas_docker.py

Loading...
View Options

hotfixes/CVE-2017-6074.sls

Loading...
View Options

hotfixes/MariaDB.sls

Loading...
View Options

hotfixes/T1261-srv-data.sls

Loading...
View Options

hotfixes/T1345-drop-jails-from-ysul.sls

Loading...
View Options

hotfixes/leap-seconds.sls

Loading...
View Options

hotfixes/old-directories.sls

Loading...
View Options

hotfixes/python3.sls

Loading...
View Options

hotfixes/salt.sls

Loading...
View Options

map.jinja

Loading...
View Options

pillar/credentials/vault.sls

Loading...
View Options

roles/bastion/pam/init.sls

Loading...
View Options

roles/bastion/sshd-otp/service.sls

Loading...
View Options

roles/bastion/sshd-otp/software.sls

Loading...
View Options

roles/bastion/yubico/authorized_yubikeys.sls

Loading...
View Options

roles/bastion/yubico/pam.sls

Loading...
View Options

roles/bastion/yubico/selinux.sls

Loading...
View Options

roles/core/certificates/letsencrypt.sls

Loading...
View Options

roles/core/hostname/init.sls

Loading...
View Options

roles/core/login/init.sls

Loading...
View Options

roles/core/memory/init.sls

Loading...
View Options

roles/core/motd/init.sls

Loading...
View Options

roles/core/network/files/ipv6-tunnels/eglide.sh.jinja

Loading...
View Options

roles/core/network/files/ipv6-tunnels/ysul.sh.jinja

Loading...
View Options

roles/core/network/gre.sls

Loading...
View Options

roles/core/network/ipv4.sls

Loading...
View Options

roles/core/network/ipv6.sls

Loading...
View Options

roles/core/network/ipv6_fixes.sls

Loading...
View Options

roles/core/network/ipv6_tunnel.sls

Loading...
View Options

roles/core/network/map.jinja

Loading...
View Options

roles/core/network/routes.sls

Loading...
View Options

roles/core/rc/init.sls

Loading...
View Options

roles/core/rsyslog/init.sls

Loading...
View Options

roles/core/salt/init.sls

Loading...
View Options

roles/core/src/init.sls

Loading...
View Options

roles/core/sshd/files/sshd_config

Loading...
View Options

roles/core/sshd/init.sls

Loading...
View Options

roles/core/storage/snapshots.sls

Loading...
View Options

roles/core/sudo/init.sls

Loading...
View Options

roles/core/sysctl/init.sls

Loading...
View Options

roles/core/timezone/init.sls

Loading...
View Options

roles/core/userland-home/init.sls

Loading...
View Options

roles/core/userland-software/base.sls

Loading...
View Options

roles/core/userland-software/sources.sls

Loading...
View Options

roles/core/userland-software/starship.sls

Loading...
View Options

roles/core/users/init.sls

Loading...
View Options

roles/dbserver-mysql/content/init.sls

Loading...
View Options

roles/dbserver-mysql/mysql-server/cnf.sls

Loading...
View Options

roles/dbserver-mysql/mysql-server/zfs.sls

Loading...
View Options

roles/dbserver-pgsql/server/content.sls

Loading...
View Options

roles/dbserver-pgsql/server/service.sls

Loading...
View Options

roles/devserver/api-exec/config.sls

Loading...
View Options

roles/devserver/datacube/init.sls

Loading...
View Options

roles/devserver/mail/init.sls

Loading...
View Options

roles/devserver/pkg/init.sls

Loading...
View Options

roles/devserver/userland-home/homefiles.sls

Loading...
View Options

roles/devserver/userland-home/repos.sls

Loading...
View Options

roles/devserver/userland-software/dev.sls

Loading...
View Options

roles/devserver/userland-software/files/notifications.conf

Loading...
View Options

roles/devserver/userland-software/files/port_options

Loading...
View Options

roles/devserver/userland-software/map.jinja

Loading...
View Options

roles/devserver/userland-software/misc.sls

Loading...
View Options

roles/devserver/userland-software/notifications.sls

Loading...
View Options

roles/devserver/userland-software/ports.sls

Loading...
View Options

roles/devserver/webserver-wwwroot51/sites.sls

Loading...
View Options

roles/dns/knot/config.sls

Loading...
View Options

roles/freebsd-repo/map.jinja

Loading...
View Options

roles/grafana/grafana/init.sls

Loading...
View Options

roles/mailserver/dkim/software.sls

Loading...
View Options

roles/mailserver/dovecot/config.sls

Loading...
View Options

roles/mailserver/dovecot/software.sls

Loading...
View Options

roles/mailserver/map.jinja

Loading...
View Options

roles/mailserver/vimbadmin/config.sls

Loading...
View Options

roles/opensearch/dashboards/config.sls

Loading...
View Options

roles/opensearch/dashboards/service.sls

Loading...
View Options

roles/opensearch/opensearch/config.sls

Loading...
View Options

roles/opensearch/opensearch/files/internal_users.yml.jinja

Loading...
View Options

roles/opensearch/opensearch/files/opensearch.conf

Loading...
View Options

roles/opensearch/opensearch/files/tlsconfig.yml.jinja

Loading...
View Options

roles/opensearch/opensearch/kernel.sls

Loading...
View Options

roles/opensearch/opensearch/security.sls

Loading...
View Options

roles/opensearch/opensearch/service.sls

Loading...
View Options

roles/opensearch/opensearch/software.sls

Loading...
View Options

roles/opensearch/opensearch/wrapper.sls

Loading...
View Options

roles/paas-docker/containers/acme_dns.sls

Loading...
View Options

roles/paas-docker/containers/airflow.sls

Loading...
View Options

roles/paas-docker/containers/aphlict.sls

Loading...
View Options

roles/paas-docker/containers/api-datasources.sls

Loading...
View Options

roles/paas-docker/containers/auth-grove.sls

Loading...
View Options

roles/paas-docker/containers/bugzilla.sls

Loading...
View Options

roles/paas-docker/containers/cachet.sls

Loading...
View Options

roles/paas-docker/containers/clickhouse.sls

Loading...
View Options

roles/paas-docker/containers/docker-registry-api.sls

Loading...
View Options

roles/paas-docker/containers/etherpad.sls

Loading...
View Options

roles/paas-docker/containers/exim.sls

Loading...
View Options

roles/paas-docker/containers/files/_tomcat/tomcat-users.xml

Loading...
View Options

roles/paas-docker/containers/hauk.sls

Loading...
View Options

roles/paas-docker/containers/hound.sls

Loading...
View Options

roles/paas-docker/containers/init.sls

Loading...
View Options

roles/paas-docker/containers/jenkins.sls

Loading...
View Options

roles/paas-docker/containers/jenkins_agent.sls

Loading...
View Options

roles/paas-docker/containers/kafka.sls

Loading...
View Options

roles/paas-docker/containers/mastodon_sidekiq.sls

Loading...
View Options

roles/paas-docker/containers/memcached.sls

Loading...
View Options

roles/paas-docker/containers/mysql.sls

Loading...
View Options

roles/paas-docker/containers/notifications.sls

Loading...
View Options

roles/paas-docker/containers/openfire.sls

Loading...
View Options

roles/paas-docker/containers/orbeon.sls

Loading...
View Options

roles/paas-docker/containers/penpot_exporter.sls

Loading...
View Options

roles/paas-docker/containers/penpot_web.sls

Loading...
View Options

roles/paas-docker/containers/phabricator.sls

Loading...
View Options

roles/paas-docker/containers/phpbb.sls

Loading...
View Options

roles/paas-docker/containers/pixelfed.sls

Loading...
View Options

roles/paas-docker/containers/postgresql.sls

Loading...
View Options

roles/paas-docker/containers/rabbitmq.sls

Loading...
View Options

roles/paas-docker/containers/redis.sls

Loading...
View Options

roles/paas-docker/containers/registry.sls

Loading...
View Options

roles/paas-docker/containers/relay.sls

Loading...
View Options

roles/paas-docker/containers/sentry.sls

Loading...
View Options

roles/paas-docker/containers/snuba.sls

Loading...
View Options

roles/paas-docker/containers/symbolicator.sls

Loading...
View Options

roles/paas-docker/containers/tommy.sls

Loading...
View Options

roles/paas-docker/containers/zookeeper.sls

Loading...
View Options

roles/paas-docker/docker/firewall.sls

Loading...
View Options

roles/paas-docker/docker/images.sls

Loading...
View Options

roles/paas-docker/docker/networks.sls

Loading...
View Options

roles/paas-docker/docker/software.sls

Loading...
View Options

roles/paas-docker/init.sls

Loading...
View Options

roles/paas-docker/kernel/init.sls

Loading...
View Options

roles/paas-docker/monitoring/init.sls

Loading...
View Options

roles/paas-docker/nginx/config.sls

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/hauk.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/openfire.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/phabricator.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/rabbitmq.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/registry.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/vault.conf

Loading...
View Options

roles/paas-docker/nginx/firewall.sls

Loading...
View Options

roles/paas-docker/nginx/selinux.sls

Loading...
View Options

roles/paas-docker/systemd-unit/init.sls

Loading...
View Options

roles/paas-docker/wrappers/init.sls

Loading...
View Options

roles/paas-docker/wwwroot-502/init.sls

Loading...
View Options

roles/paas-docker/wwwroot-content/base.sls

Loading...
View Options

roles/paas-docker/wwwroot-content/selinux.sls

Loading...
View Options

roles/paas-jails/jails/init.sls

Loading...
View Options

roles/paas-lxc/lxc/init.sls

Loading...
View Options

roles/prometheus/prometheus/service.sls

Loading...
View Options

roles/redis/server/service.sls

Loading...
View Options

roles/router/carp/files/carp.rc

Loading...
View Options

roles/router/carp/init.sls

Loading...
View Options

roles/saas-mediawiki/data/init.sls

Loading...
View Options

roles/saas-mediawiki/mediawiki/config.sls

Loading...
View Options

roles/saas-mediawiki/mediawiki/interwiki.sls

Loading...
View Options

roles/saas-mediawiki/mediawiki/software.sls

Loading...
View Options

roles/saas-mediawiki/nginx/config.sls

Loading...
View Options

roles/saas-mediawiki/software/init.sls

Loading...
View Options

roles/salt-primary/account/init.sls

Loading...
View Options

roles/salt-primary/service/init.sls

Loading...
View Options

roles/shellserver/odderon/service.sls

Loading...
View Options

roles/shellserver/quassel-core/changepassword.sls

Loading...
View Options

roles/shellserver/quassel-core/map.jinja

Loading...
View Options

roles/shellserver/quassel-core/software.sls

Loading...
View Options

roles/shellserver/userland-software/base.sls

Loading...
View Options

roles/shellserver/userland-software/irc.sls

Loading...
View Options

roles/shellserver/vault/config.sls

Loading...
View Options

roles/shellserver/vhosts/init.sls

Loading...
View Options

roles/shellserver/web-hosting/init.sls

Loading...
View Options

roles/vault/policies/init.sls

Loading...
View Options

roles/vault/vault/init.sls

Loading...
View Options

roles/viperserv/account/init.sls

Loading...
View Options

roles/viperserv/eggdrop/config.sls

Loading...
View Options

roles/viperserv/eggdrop/cron.sls

Loading...
View Options

roles/viperserv/eggdrop/service.sls

Loading...
View Options

roles/viperserv/eggdrop/software.sls

Loading...
View Options

roles/viperserv/fantoir/init.sls

Loading...
View Options

roles/viperserv/rabbitmq-tcl/init.sls

Loading...
View Options

roles/viperserv/wikidata-access-layer/code.sls

Loading...
View Options

roles/webserver-alkane/account/init.sls

Loading...
View Options

roles/webserver-alkane/alkane/init.sls

Loading...
View Options

roles/webserver-alkane/directories/init.sls

Loading...
View Options

roles/webserver-alkane/php/cleanup.sls

Loading...
View Options

roles/webserver-alkane/php/files/php-fpm-pool.conf

Loading...
View Options

roles/webserver-alkane/php/php-fpm.sls

Loading...
View Options

roles/webserver-alkane/php/php.sls

Loading...
View Options

roles/webserver-alkane/php/service.sls

Loading...
View Options

roles/webserver-content/org/eglide/www.sls

Loading...
View Options

roles/webserver-content/org/nasqueron/labs.sls

Loading...
View Options

roles/webserver-content/org/wolfplex/api.sls

Loading...
View Options

roles/webserver-content/space/hypership/www.sls

Loading...
View Options

roles/webserver-core/nginx/config.sls

Loading...
View Options

roles/webserver-legacy/jenkins-cd/content.sls

Loading...
View Options

roles/webserver-legacy/php-sites/files.sls

Loading...
View Options

roles/webserver-legacy/php-sites/files/php-fpm-pool.conf

Loading...
View Options

roles/webserver-legacy/php-sites/php-fpm.sls

Loading...
View Options

roles/webserver-legacy/php-sites/php.sls

Loading...
View Options

roles/webserver-legacy/static-sites/init.sls

Loading...
View Options

roles/webserver-legacy/tweaks/autochmod.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator