Differential D4086

Add convenience XHubSignature256 class to default to SHA-256
ClosedPublic
Actions

Authored by dereckson on Sun, Apr 19, 18:48.

Tags

None

Referenced Files

	F27069172: D4086.id10714.diff
	Tue, Apr 28, 21:10

	F26986145: D4086.id10714.diff
	Tue, Apr 28, 09:39

	Unknown Object (File)
	Mon, Apr 27, 11:00

	Unknown Object (File)
	Mon, Apr 27, 02:59

	Unknown Object (File)
	Mon, Apr 27, 02:28

	Unknown Object (File)
	Mon, Apr 27, 01:54

	Unknown Object (File)
	Sun, Apr 26, 21:15

	Unknown Object (File)
	Sun, Apr 26, 17:18

View All 53 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T2310: Support X-Hub-Signature-256

Commits

rKERUALDc238704561c9: Add convenience XHubSignature256 class to default to SHA-256

Summary

To update the default algo doesn't a good approach, especially as GitHub
has chosen to update the header from X-Hub-Signature to X-Hub-Signature-256.

This is a weird inheritance case where we would like to impose SHA-256
as algorithm but where the parent class allows algorithm override.

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Sun, Apr 19, 18:48

dereckson created this revision.

Harbormaster completed remote builds in B6652: Diff 10689.Sun, Apr 19, 18:48

To put tests in a namespace is certainly a good idea, but that will be in a follow-up commit.

dereckson added a parent revision: D4079: Test X-Hub-Signature-256 documentation values.Sun, Apr 19, 18:50

Algo can be overriden

Harbormaster completed remote builds in B6653: Diff 10690.Sun, Apr 19, 18:52

Algo can be overriden

Harbormaster completed remote builds in B6654: Diff 10691.Sun, Apr 19, 18:53

Unit tests

WindRiver

$ phpunit github
Switching to Composer phpunit:
PHPUnit 12.5-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.30
Configuration: /home/dereckson/dev/keruald/_monorepo/core/phpunit.xml

........                                                            8 / 8 (100%)

Time: 00:00.016, Memory: 16.00 MB

OK (8 tests, 14 assertions)

Tests seem to require 8111582dd667f98fc11bd50e98b7a9e2d33ff149 to work, but change isn't rebased.

dereckson accepted this revision.Sat, Apr 25, 17:29

This revision is now accepted and ready to land.Sat, Apr 25, 17:29

This revision was landed with ongoing or failed builds.Sat, Apr 25, 17:30

Closed by commit rKERUALDc238704561c9: Add convenience XHubSignature256 class to default to SHA-256 (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALDc238704561c9: Add convenience XHubSignature256 class to default to SHA-256.

Revision Contents
Changeset List

Path

Size

github/

src/

XHubSignature256.php

66 lines

tests/

XHubSignature256Test.php

39 lines

Diff 10714

github/src/XHubSignature256.php

Loading...

github/tests/XHubSignature256Test.php

Loading...