dashboard without trailing slash
Needs ReviewPublic
Actions

Authored by ptdradmin on Tue, Jul 21, 03:38.

Details

Reviewers

Maniphest Tasks

T2289: https://infra.nasqueron.org/cd/dashboard without trailing slash doesn't serve CSS

Summary

The prefix location /cd/dashboard proxied requests without a trailing
slash directly to Tommy CD, so the browser resolved relative CSS/JS
assets against /cd/ instead of /cd/dashboard/, breaking the styling.

Redirect the exact /cd/dashboard path to /cd/dashboard/ first, same
pattern already used for /cd and /cd/.

Refs T2289

Test Plan

Verified the location block logic mirrors the existing /cd and /cd/
redirect pattern already deployed for this vhost. Manual check on
web-001 recommended once deployed: hit https://infra.nasqueron.org/cd/dashboard
without a trailing slash and confirm CSS loads.

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Skipped

Unit

No Test Coverage

Branch

main

Build Status

Buildable 6761
Build 7049: arc lint + arc unit

Event Timeline

ptdradmin requested review of this revision.Tue, Jul 21, 03:38

ptdradmin created this revision.

Harbormaster completed remote builds in B6757: Diff 10843.Tue, Jul 21, 03:38

ptdradmin mentioned this in D4135: Make innodb_buffer_pool_size configurable per node.Tue, Jul 21, 04:17

I see 3 blocks with the same 302 redirect.

Can we try this to replace lines 49 to 60?

location ~ ^/cd(?:/|/dashboard)?$ {
    return 302 https://infra.nasqueron.org/cd/dashboard/;
}

(to test together before merging I guess)

Merge the three exact-match redirect blocks (/cd, /cd/, /cd/dashboard) into a single regex location, as suggested: location ~ ^/cd(?:/|/dashboard)?$ { ... }

Harbormaster completed remote builds in B6761: Diff 10847.Tue, Jul 21, 20:37

Merge the three exact-match redirect blocks (/cd, /cd/, /cd/dashboard) into a single regex location, as suggested.

Harbormaster completed remote builds in B6762: Diff 10848.Tue, Jul 21, 20:38