Details

Reviewers

dereckson

Commits

rOPSaf607c8a9104: Validate salt-tower pillar files with JSON Schema

Summary

JSON Schema has been selected to offer validation in IDE.

The pillar files we validate are the pillar defined in tower.sls,
as we create new files for new servers or services.

Test Plan

New tests pass

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Errors

Severity	Location	Code	Message
Error	_tests/pillar/dbserver/test_postgresql.py:78	E501	flake8 E501

Unit

No Test Coverage

Branch

codex-pillar-tests

Build Status

Buildable 6795
Build 7083: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Wed, Aug 5, 07:15

dereckson created this revision.

Harbormaster completed remote builds in B6779: Diff 10872.Wed, Aug 5, 07:15

I wonder if T1681 couldn't host them too. If so:

"$id": "https://operations.nasqueron.org/schemas/pillar/certificates.schema.json",

should become:

"$id": "https://schema.nasqueron.org/operations/pillar/certificates.schema.json",

Models used:

GPT 5.5 (Codex, from JetBrains PyCharm) for the schema generation and the tests
Qwen 3.8 for code review

Use the schema.nasqueron.org namespace by coherence with D2532.

Declare the schema files as non versioned. The /unversioned/ URL part says
“this schema has no schema-version dimension”.

Harbormaster completed remote builds in B6795: Diff 10895.Mon, Aug 10, 21:26

Headers

Harbormaster completed remote builds in B6796: Diff 10896.Mon, Aug 10, 21:36

+subject_alternative_names per D4146 / 1b2ff5a0c350.

Harbormaster completed remote builds in B6797: Diff 10897.Mon, Aug 10, 21:42

dereckson accepted this revision.Mon, Aug 10, 21:45

This revision is now accepted and ready to land.Mon, Aug 10, 21:45

This revision was landed with ongoing or failed builds.Mon, Aug 10, 21:45

Closed by commit rOPSaf607c8a9104: Validate salt-tower pillar files with JSON Schema (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOPSaf607c8a9104: Validate salt-tower pillar files with JSON Schema.

Validate salt-tower pillar files with JSON Schema
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 10895

.vscode/settings.json

README.md

_resources/schemas/pillar/certificates.schema.json

_resources/schemas/pillar/dbserver.schema.json

_resources/schemas/pillar/dns.schema.json

_resources/schemas/pillar/nextcloud.schema.json

_resources/schemas/pillar/paas-alkane.schema.json

_resources/schemas/pillar/paas-docker.schema.json

_resources/schemas/pillar/webserver.schema.json

_tests/pillar/core/test_certificates_schema.py

_tests/pillar/dbserver/test_postgresql.py

_tests/pillar/dns/init.py

_tests/pillar/dns/test_schema.py

_tests/pillar/paas/test_alkane_schema.py

_tests/pillar/paas/test_docker.py

_tests/pillar/saas/init.py

_tests/pillar/saas/test_nextcloud_schema.py

_tests/pillar/schema_helpers.py

_tests/pillar/webserver/init.py

_tests/pillar/webserver/test_schema.py

requirements.txt

Validate salt-tower pillar files with JSON SchemaClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10895

.vscode/settings.json

README.md

_resources/schemas/pillar/certificates.schema.json

_resources/schemas/pillar/dbserver.schema.json

_resources/schemas/pillar/dns.schema.json

_resources/schemas/pillar/nextcloud.schema.json

_resources/schemas/pillar/paas-alkane.schema.json

_resources/schemas/pillar/paas-docker.schema.json

_resources/schemas/pillar/webserver.schema.json

_tests/pillar/core/test_certificates_schema.py

_tests/pillar/dbserver/test_postgresql.py

_tests/pillar/dns/__init__.py

_tests/pillar/dns/test_schema.py

_tests/pillar/paas/test_alkane_schema.py

_tests/pillar/paas/test_docker.py

_tests/pillar/saas/__init__.py

_tests/pillar/saas/test_nextcloud_schema.py

_tests/pillar/schema_helpers.py

_tests/pillar/webserver/__init__.py

_tests/pillar/webserver/test_schema.py

requirements.txt

Validate salt-tower pillar files with JSON Schema
ClosedPublic
Actions

Revision Contents
Changeset List

_tests/pillar/dns/init.py

_tests/pillar/saas/init.py

_tests/pillar/webserver/init.py