Page MenuHomeDevCentral
Differential D559

Set call for actions buttons back to 100% in smaller viewports
ClosedPublic
Actions

Authored by dereckson on Jul 24 2016, 22:09.
Tags
None
Referenced Files
F35162114: D559.diff
Tue, Jul 7, 04:39
F35071583: D559.id1361.diff
Mon, Jul 6, 14:14
Unknown Object (File)
Fri, Jul 3, 21:58
Unknown Object (File)
Fri, Jul 3, 14:43
Unknown Object (File)
Fri, Jul 3, 12:37
Unknown Object (File)
Thu, Jul 2, 21:33
Unknown Object (File)
Wed, Jul 1, 11:16
Unknown Object (File)
Fri, Jun 26, 06:28
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rVIPERWWW841e131a8fdf: Set call for actions buttons back to 100% in smaller viewports
Summary

In a first design iteration, the button was at 100% width.

When switched from an element a to an element input to submit
a form to build the target URL in 6985ba335c86, we lost this feature,
welcome to be a more bold call for action.

This commit fixes a regression introduced in 6985ba335c86.

Test Plan

Tested with a view port < 640 px.

Diff Detail

Repository
rVIPERWWW Dæghrefn website
Lint
Lint Passed
Unit
No Test Coverage
Branch
fix-actions-button
Build Status
Buildable 819
Build 953: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1361.Jul 24 2016, 22:09
dereckson retitled this revision from to Set call for actions buttons back to 100% in smaller viewports.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson accepted this revision.Jul 24 2016, 22:25
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2016, 22:25
Closed by commit rVIPERWWW841e131a8fdf: Set call for actions buttons back to 100% in smaller viewports (authored by dereckson, committed by dereckson). · Explain WhyJul 24 2016, 22:26
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
3 lines
src/
assets/
scss/
components/
1 line

Diff 1361

View Options

CHANGELOG.md

Loading...
View Options

src/assets/scss/components/_actions.scss

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator