Avoid shadow variable name
ClosedPublic
Actions

Authored by dereckson on Jul 25 2016, 04:01.

Tags

None

Referenced Files

	F45499743: D569.id.diff
	Sat, Aug 22, 10:55

	F45356078: D569.id1382.diff
	Fri, Aug 21, 21:21

	F45337195: D569.id1515.diff
	Fri, Aug 21, 19:16

	Unknown Object (File)
	Thu, Aug 20, 19:22

	Unknown Object (File)
	Thu, Aug 20, 17:11

	Unknown Object (File)
	Mon, Aug 17, 16:28

	Unknown Object (File)
	Mon, Aug 17, 14:14

	Unknown Object (File)
	Mon, Aug 17, 14:13

View All Files

Subscribers

None

Details

Reviewers

• Ash-Crow

Commits

rDWDa991d5d09084: Avoid shadow variable name

Summary

file → translations_file

Test Plan

$ cat > test.dat
fr	pomme
en	apple
^D
$ spreadsheet2json test.dat

Diff Detail

Repository

rDWD Dæghrefn Wikidata access layer

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-shadow

Build Status

Buildable 836
Build 970: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1382.Jul 25 2016, 04:01

dereckson retitled this revision from to Avoid shadow variable name.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: • Ash-Crow.

• Ash-Crow accepted this revision.Aug 19 2016, 06:38

• Ash-Crow edited edge metadata.

This revision is now accepted and ready to land.Aug 19 2016, 06:38

Closed by commit rDWDa991d5d09084: Avoid shadow variable name (authored by dereckson, committed by dereckson). · Explain WhyAug 19 2016, 10:38

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tools/

spreadsheet2json

4 lines

Diff 1382

View Options

Avoid shadow variable nameClosedPublicActions