Page MenuHomeDevCentral

Honour Application abstract contract in ReportServiceProvider
ClosedPublic

Authored by dereckson on Dec 28 2016, 03:45.
Tags
None
Referenced Files
F25170754: D771.diff
Fri, Apr 3, 01:08
F25158218: D771.diff
Thu, Apr 2, 08:25
Unknown Object (File)
Wed, Apr 1, 10:33
Unknown Object (File)
Tue, Mar 31, 12:25
Unknown Object (File)
Tue, Mar 31, 00:35
Unknown Object (File)
Mon, Mar 30, 12:05
Unknown Object (File)
Sun, Mar 29, 12:21
Unknown Object (File)
Sat, Mar 28, 23:04
Subscribers

Details

Summary

Laravel Container and so Application classes offer to access services:

  • using the make method in the abstract contract
  • through ArrayAccess in the concrete implementation

We used array access, but documented ReportServiceProvider::register
is happy to accept any \Illuminate\Contracts\Foundation\Application.

To honour this claim, we so switch to use the make method.

This is a follow-up to 6ed92b9a75b8.

This fixes the following phan issue:

app/Providers/ReportServiceProvider.php:21
PhanTypeArraySuspicious
Suspicious array access to \Illuminate\Contracts\Foundation\Application
Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
suspicious-array-access (branched from master)

Event Timeline

dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 11:26
This revision was automatically updated to reflect the committed changes.