Paths

Table of Contentst

Prune extraneous unused parameter
ClosedPublic
Actions

Authored by dereckson on Dec 29 2016, 19:43.

Tags

None

Referenced Files

	F18091248: D773.id1956.diff
	Wed, Dec 17, 14:25

	Unknown Object (File)
	Tue, Dec 16, 09:17

	Unknown Object (File)
	Sun, Dec 14, 04:24

	Unknown Object (File)
	Wed, Dec 10, 14:26

	Unknown Object (File)
	Tue, Dec 9, 23:49

	Unknown Object (File)
	Tue, Dec 9, 08:39

	Unknown Object (File)
	Tue, Dec 9, 03:29

	Unknown Object (File)
	Sun, Dec 7, 19:50

View All Files

Subscribers

alken-orin

Details

Reviewers

dereckson

Commits

rNOTIF8c415781711f: Prune extraneous unused parameter

Summary

BasePayloadAnalyzer::loadConfiguration uses $this->project
and so doesn't need anymore the project as parameter.

Test Plan

Run tests
Run phan, check there isn't any PhanParamTooMany

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

+PhabricatorPayloadAnalyzer

Build is green https://ci.nasqueron.org/job/test-notifications-phab/234/ for more details.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/235/ for more details.

dereckson accepted this revision.Dec 29 2016, 19:58

dereckson edited edge metadata.

This revision is now accepted and ready to land.Dec 29 2016, 19:58

Closed by commit rNOTIF8c415781711f: Prune extraneous unused parameter (authored by dereckson, committed by dereckson). · Explain WhyDec 29 2016, 19:59

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Analyzers/

BasePayloadAnalyzer.php

2 lines

Phabricator/

PhabricatorPayloadAnalyzer.php

2 lines

Diff 1957

View Options

app/Analyzers/BasePayloadAnalyzer.php