Page MenuHomeDevCentral
Differential D821

Refactor .tcl DCC command
ClosedPublic
Actions

Authored by dereckson on Jan 12 2017, 05:14.
Tags
None
Referenced Files
F12598476: D821.diff
Tue, Nov 11, 23:03
F12565549: D821.id.diff
Mon, Nov 10, 23:51
Unknown Object (File)
Sun, Nov 9, 10:00
Unknown Object (File)
Sun, Nov 9, 07:32
Unknown Object (File)
Mon, Nov 3, 07:50
Unknown Object (File)
Mon, Nov 3, 00:19
Unknown Object (File)
Sun, Nov 2, 17:16
Unknown Object (File)
Sun, Nov 2, 17:01
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rVIPER1dab92b91711: Refactor .tcl DCC command
Summary
  • separate concern of decide if we need to log in a standalone proc
  • add genpass to the commands not to log
  • unit tests
Test Plan

make test

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
should_log_tcl_command
Build Status
Buildable 1259
Build 1507: arc lint + arc unit

Event Timeline

dereckson created this revision.Jan 12 2017, 05:14
dereckson accepted this revision.Jan 12 2017, 05:16
This revision is now accepted and ready to land.Jan 12 2017, 05:16
Closed by commit rVIPER1dab92b91711: Refactor .tcl DCC command (authored by dereckson, committed by dereckson). · Explain WhyJan 12 2017, 05:16
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
16 lines
tests/
36 lines

Diff 2078

View Options

Tech.tcl

Loading...
View Options

tests/Tech.test

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator