Fix null exception when Phabricator repository is private
ClosedPublic
Actions

Authored by dereckson on Jan 28 2017, 00:01.

Tags

None

Referenced Files

	F21251749: D872.diff
	Tue, Jan 20, 19:38

	F21224198: D872.id.diff
	Tue, Jan 20, 13:09

	Unknown Object (File)
	Mon, Jan 19, 14:12

	Unknown Object (File)
	Sun, Jan 18, 22:10

	Unknown Object (File)
	Fri, Jan 16, 01:00

	Unknown Object (File)
	Thu, Jan 15, 22:37

	Unknown Object (File)
	Thu, Jan 15, 20:49

	Unknown Object (File)
	Tue, Jan 13, 06:42

View All Files

Subscribers

None

Details

Reviewers

dereckson

Maniphest Tasks

T1136: Null exception in PhabricatorStory::getRepositoryPHID() when notifications user account doesn't have an access

Commits

rNOTIFf5e62b25cc8d: Fix null exception when Phabricator repository is private

Summary

When a repository is private and can't be reached by the bot account
used to fetch Phabricator information, a null exception occurs in
PhabricatorStory::getRepositoryPHID method.

This change handles the case an API query doesn't contain the
required information.

Fixes T1136.

Test Plan

Fire again the notification.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Jan 28 2017, 00:01

dereckson accepted this revision.Jan 28 2017, 00:02

This revision is now accepted and ready to land.Jan 28 2017, 00:02

Closed by commit rNOTIFf5e62b25cc8d: Fix null exception when Phabricator repository is private (authored by dereckson, committed by dereckson). · Explain WhyJan 28 2017, 00:03

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorStory.php

11 lines

Diff 2216

View Options

app/Phabricator/PhabricatorStory.php

Fix null exception when Phabricator repository is privateClosedPublicActions