Page Menu
Home
DevCentral
Search
Configure Global Search
Log In
Files
F10818249
D769.id1948.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
15 KB
Referenced Files
None
Subscribers
None
D769.id1948.diff
View Options
diff --git a/app/Actions/Action.php b/app/Actions/Action.php
--- a/app/Actions/Action.php
+++ b/app/Actions/Action.php
@@ -9,7 +9,7 @@
public $action;
/**
- * @var Nasqueron\Notifications\Actions\ActionError
+ * @var ActionError
*/
public $error;
@@ -28,7 +28,7 @@
* $actionToReport->attachError(new ActionError($exception));
* </code>
*
- * @param Nasqueron\Notifications\Actions\ActionError $error The error to attach
+ * @param ActionError $error The error to attach
*/
public function attachError (ActionError $error) {
$this->error = $error;
diff --git a/app/Analyzers/BasePayloadAnalyzer.php b/app/Analyzers/BasePayloadAnalyzer.php
--- a/app/Analyzers/BasePayloadAnalyzer.php
+++ b/app/Analyzers/BasePayloadAnalyzer.php
@@ -22,13 +22,13 @@
/**
* The request content, as a structured data
- * @var stdClass
+ * @var \stdClass
*/
protected $payload;
/**
* The configuration for the payload analyzer
- * @var Nasqueron\Notifications\Analyzers\BasePayloadAnalyzerConfiguration;
+ * @var BasePayloadAnalyzerConfiguration;
*/
protected $configuration;
@@ -40,7 +40,7 @@
* Creates a new JenkinsPayloadAnalyzer instance.
*
* @param string $project
- * @param stdClass $payload
+ * @param \stdClass $payload
*/
public function __construct($project, $payload) {
if (!is_object($payload)) {
diff --git a/app/Analyzers/GitHub/Events/PushEvent.php b/app/Analyzers/GitHub/Events/PushEvent.php
--- a/app/Analyzers/GitHub/Events/PushEvent.php
+++ b/app/Analyzers/GitHub/Events/PushEvent.php
@@ -16,7 +16,7 @@
* Gets the description message key according the amount of commits
*
* @param int $count The count of commits
- * @return The l10n message key for description
+ * @return string The l10n message key for description
*/
private static function getDescriptionMessageKey ($count) {
$key = 'GitHub.EventsDescriptions.PushEvent';
diff --git a/app/Analyzers/GitHub/GitHubPayloadAnalyzer.php b/app/Analyzers/GitHub/GitHubPayloadAnalyzer.php
--- a/app/Analyzers/GitHub/GitHubPayloadAnalyzer.php
+++ b/app/Analyzers/GitHub/GitHubPayloadAnalyzer.php
@@ -26,7 +26,7 @@
/**
* The payload analyzer event
*
- * @var Nasqueron\Notifications\Analyzers\GitHub\Events\Event;
+ * @var \Nasqueron\Notifications\Analyzers\GitHub\Events\Event;
*/
private $analyzerEvent;
@@ -39,7 +39,7 @@
*
* @param string $project
* @param string $event
- * @param stdClass $payload
+ * @param \stdClass $payload
*/
public function __construct($project, $event, $payload) {
parent::__construct($project, $payload);
diff --git a/app/Console/Commands/NotificationsPayload.php b/app/Console/Commands/NotificationsPayload.php
--- a/app/Console/Commands/NotificationsPayload.php
+++ b/app/Console/Commands/NotificationsPayload.php
@@ -169,7 +169,7 @@
* Initializes a new instance of the relevant notification class,
* with the arguments given in the constructor property.
*
- * @return Nasqueron\Notifications\Notification
+ * @return \Nasqueron\Notifications\Notification
*/
private function getNotification () {
$class = $this->getNotificationClass();
diff --git a/app/Contracts/APIFactory.php b/app/Contracts/APIFactory.php
--- a/app/Contracts/APIFactory.php
+++ b/app/Contracts/APIFactory.php
@@ -8,7 +8,7 @@
* Gets an instance of the API client class
*
* @param string $endPoint The API end point
- * @return Nasqueron\Notifications\Contracts\APIClient
+ * @return APIClient
*/
public function get ($endPoint);
diff --git a/app/Jobs/FireDockerHubNotification.php b/app/Jobs/FireDockerHubNotification.php
--- a/app/Jobs/FireDockerHubNotification.php
+++ b/app/Jobs/FireDockerHubNotification.php
@@ -43,7 +43,7 @@
* Creates a DockerHub notification
*
* @param DockerHubPayloadEvent $event
- * @return Notification the notification
+ * @return \Nasqueron\Notifications\Notification The notification
*/
protected function createNotification() {
return new DockerHubNotification(
diff --git a/app/Jobs/FireGitHubNotification.php b/app/Jobs/FireGitHubNotification.php
--- a/app/Jobs/FireGitHubNotification.php
+++ b/app/Jobs/FireGitHubNotification.php
@@ -43,7 +43,7 @@
* Creates a GitHub notification
*
* @param GitHubPayloadEvent $event
- * @return Notification the notification
+ * @return \Nasqueron\Notifications\Notification The notification
*/
protected function createNotification() {
return new GitHubNotification(
diff --git a/app/Jobs/FireJenkinsNotification.php b/app/Jobs/FireJenkinsNotification.php
--- a/app/Jobs/FireJenkinsNotification.php
+++ b/app/Jobs/FireJenkinsNotification.php
@@ -45,7 +45,7 @@
* Creates a Jenkins notification
*
* @param JenkinsPayloadEvent $event
- * @return Notification the notification
+ * @return \Nasqueron\Notifications\Notification The notification
*/
protected function createNotification() {
return new JenkinsNotification(
diff --git a/app/Jobs/FirePhabricatorNotification.php b/app/Jobs/FirePhabricatorNotification.php
--- a/app/Jobs/FirePhabricatorNotification.php
+++ b/app/Jobs/FirePhabricatorNotification.php
@@ -43,7 +43,7 @@
* Creates a Phabricator notification
*
* @param PhabricatorPayloadEvent $event
- * @return Notification the notification
+ * @return \Nasqueron\Notifications\Notification The notification
*/
protected function createNotification() {
return new PhabricatorNotification(
diff --git a/app/Notifications/PhabricatorNotification.php b/app/Notifications/PhabricatorNotification.php
--- a/app/Notifications/PhabricatorNotification.php
+++ b/app/Notifications/PhabricatorNotification.php
@@ -35,7 +35,7 @@
/**
* Gets analyzer
*
- * @return Nasqueron\Notifications\Analyzers\Phabricator\PhabricatorPayloadAnalyzer
+ * @return \Nasqueron\Notifications\Analyzers\Phabricator\PhabricatorPayloadAnalyzer
*/
private function getAnalyzer () {
if ($this->analyzer === null) {
diff --git a/app/Phabricator/PhabricatorAPIFactory.php b/app/Phabricator/PhabricatorAPIFactory.php
--- a/app/Phabricator/PhabricatorAPIFactory.php
+++ b/app/Phabricator/PhabricatorAPIFactory.php
@@ -10,7 +10,7 @@
* Gets an instance of the Phabricator API client class.
*
* @param string $instance The Phabricator instance
- * @return Nasqueron\Notifications\Phabricator\PhabricatorAPI
+ * @return \Nasqueron\Notifications\Phabricator\PhabricatorAPI
*/
public function get ($instance) {
return PhabricatorAPI::forInstance($instance);
@@ -20,7 +20,7 @@
* Gets an instance of the Phabricator API client class for a project.
*
* @param string $project The Phabricator project name
- * @return Nasqueron\Notifications\Phabricator\PhabricatorAPI
+ * @return PhabricatorAPI
*/
public function getForProject ($project) {
return PhabricatorAPI::forProject($project);
diff --git a/app/Phabricator/ProjectsMap.php b/app/Phabricator/ProjectsMap.php
--- a/app/Phabricator/ProjectsMap.php
+++ b/app/Phabricator/ProjectsMap.php
@@ -34,7 +34,7 @@
/**
*
- * @var Nasqueron\Notifications\Contracts\APIClient
+ * @var \Nasqueron\Notifications\Contracts\APIClient
*/
private $apiClient;
@@ -140,7 +140,7 @@
* Gets a new ProjectsMap instance and queries Phabricator API to fill it.
*
* @param string $phabricatorInstanceName The Phabricator instance name
- * @param Nasqueron\Notifications\Contracts\APIClient $apiClient The Phabricator API client
+ * @param \Nasqueron\Notifications\Contracts\APIClient $apiClient The Phabricator API client
* @return ProjectsMap
*/
public static function fetch ($phabricatorInstanceName, ?APIClient $apiClient = null) {
@@ -155,7 +155,7 @@
///
/**
- * @return Nasqueron\Notifications\Contracts\APIClient
+ * @return \Nasqueron\Notifications\Contracts\APIClient
*/
public function getAPIClient () {
if ($this->apiClient === null) {
@@ -166,7 +166,7 @@
}
/**
- * @param Nasqueron\Notifications\Contracts\APIClient $apiClient
+ * @param \Nasqueron\Notifications\Contracts\APIClient|null $apiClient
*/
public function setAPIClient (?APIClient $apiClient = null) {
$this->apiClient = $apiClient;
diff --git a/app/Phabricator/ProjectsMapFactory.php b/app/Phabricator/ProjectsMapFactory.php
--- a/app/Phabricator/ProjectsMapFactory.php
+++ b/app/Phabricator/ProjectsMapFactory.php
@@ -8,7 +8,7 @@
* Loads projects map from cache or fetches it from API if not cached.
*
* @param string $instanceName The Phabricator instance name
- * @return Nasqueron\Notifications\Phabricator\ProjectsMap
+ * @return ProjectsMap
*/
public function load ($instanceName) {
return ProjectsMap::load($instanceName);
@@ -18,7 +18,7 @@
* Fetches projects map from API.
*
* @param string $instanceName The Phabricator instance name
- * @return Nasqueron\Notifications\Phabricator\ProjectsMap
+ * @return ProjectsMap
*/
public function fetch ($instanceName) {
return ProjectsMap::fetch($instanceName);
diff --git a/app/Providers/ReportServiceProvider.php b/app/Providers/ReportServiceProvider.php
--- a/app/Providers/ReportServiceProvider.php
+++ b/app/Providers/ReportServiceProvider.php
@@ -26,8 +26,8 @@
/**
* Listen to actions fired by the application to add to the report
*
- * @param Nasqueron\Notifications\Actions\ActionsReport $report The report to add actions to
- * @param Illuminate\Contracts\Events\Dispatcher $events The application events dispatcher
+ * @param \Nasqueron\Notifications\Actions\ActionsReport $report The report to add actions to
+ * @param \Illuminate\Contracts\Events\Dispatcher $events The application events dispatcher
*/
public static function listenToActionsForReport (ActionsReport $report, Dispatcher $events) {
$events->listen(
diff --git a/tests/Analyzers/GitHub/Events/UnknownEventTest.php b/tests/Analyzers/GitHub/Events/UnknownEventTest.php
--- a/tests/Analyzers/GitHub/Events/UnknownEventTest.php
+++ b/tests/Analyzers/GitHub/Events/UnknownEventTest.php
@@ -8,7 +8,7 @@
class UnknownEventTest extends TestCase {
/**
- * @var Nasqueron\Notifications\Analyzers\GitHub\Events\UnknownEvent
+ * @var \Nasqueron\Notifications\Analyzers\GitHub\Events\UnknownEvent
*/
private $event;
diff --git a/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php b/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
--- a/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
+++ b/tests/Analyzers/GitHub/GitHubPayloadAnalyzerTest.php
@@ -8,22 +8,22 @@
class GitHubPayloadAnalyzerTest extends TestCase {
/**
- * @var Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
+ * @var \Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
*/
private $unknownEventAnalyzer;
/**
- * @var Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
+ * @var \Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
*/
private $pingAnalyzer;
/**
- * @var Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
+ * @var \Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
*/
private $pushAnalyzer;
/**
- * @var Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
+ * @var \Nasqueron\Notifications\Analyzers\GitHub\GitHubPayloadAnalyzer
*/
private $pushToMappedRepositoryAnalyzer;
diff --git a/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php b/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php
--- a/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php
+++ b/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerConfigurationTest.php
@@ -13,7 +13,7 @@
/**
* Configuration
*
- * @var Nasqueron\Notifications\Analyzers\Jenkins\JenkinsPayloadAnalyzerConfiguration
+ * @var \Nasqueron\Notifications\Analyzers\Jenkins\JenkinsPayloadAnalyzerConfiguration
*/
protected $configuration;
diff --git a/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerTest.php b/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerTest.php
--- a/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerTest.php
+++ b/tests/Analyzers/Jenkins/JenkinsPayloadAnalyzerTest.php
@@ -11,7 +11,7 @@
/**
* Jenkins analyzer to a successful build
*
- * @var Nasqueron\Notifications\Analyzers\Jenkins\JenkinsPayloadAnalyzer
+ * @var \Nasqueron\Notifications\Analyzers\Jenkins\JenkinsPayloadAnalyzer
*/
protected $analyzer;
diff --git a/tests/Analyzers/PayloadAnalyzerConfigurationTest.php b/tests/Analyzers/PayloadAnalyzerConfigurationTest.php
--- a/tests/Analyzers/PayloadAnalyzerConfigurationTest.php
+++ b/tests/Analyzers/PayloadAnalyzerConfigurationTest.php
@@ -13,7 +13,7 @@
/**
* Configuration
*
- * @var Nasqueron\Notifications\Analyzers\PayloadAnalyzerConfiguration
+ * @var \Nasqueron\Notifications\Analyzers\PayloadAnalyzerConfiguration
*/
protected $configuration;
diff --git a/tests/Notifications/DockerHubNotificationTest.php b/tests/Notifications/DockerHubNotificationTest.php
--- a/tests/Notifications/DockerHubNotificationTest.php
+++ b/tests/Notifications/DockerHubNotificationTest.php
@@ -14,7 +14,7 @@
use WithMockHttpClient;
/**
- * @return Nasqueron\Notifications\Notifications\DockerHubNotification
+ * @return \Nasqueron\Notifications\Notifications\DockerHubNotification
*/
protected function prepareNotification ($event) {
$path = __DIR__ . '/../data/payloads/DockerHub' . ucfirst($event)
diff --git a/tests/Notifications/JenkinsNotificationTest.php b/tests/Notifications/JenkinsNotificationTest.php
--- a/tests/Notifications/JenkinsNotificationTest.php
+++ b/tests/Notifications/JenkinsNotificationTest.php
@@ -7,7 +7,7 @@
class JenkinsNotificationTest extends TestCase {
/**
- * @var Nasqueron\Notifications\Notifications\JenkinsNotification
+ * @var \Nasqueron\Notifications\Notifications\JenkinsNotification
*/
private $notification;
diff --git a/tests/Phabricator/ProjectsMapTest.php b/tests/Phabricator/ProjectsMapTest.php
--- a/tests/Phabricator/ProjectsMapTest.php
+++ b/tests/Phabricator/ProjectsMapTest.php
@@ -11,7 +11,7 @@
class ProjectsMapTest extends TestCase {
/**
- * @var Nasqueron\Notifications\Phabricator\ProjectsMap
+ * @var \Nasqueron\Notifications\Phabricator\ProjectsMap
*/
private $map;
diff --git a/tests/Services/ServiceTest.php b/tests/Services/ServiceTest.php
--- a/tests/Services/ServiceTest.php
+++ b/tests/Services/ServiceTest.php
@@ -8,12 +8,12 @@
class ServiceTest extends TestCase {
/**
- * @var Nasqueron\Notifications\Services\Service
+ * @var \Nasqueron\Notifications\Services\Service
*/
private $serviceWithInstance;
/**
- * @var Nasqueron\Notifications\Services\Service
+ * @var \Nasqueron\Notifications\Services\Service
*/
private $serviceWithoutInstance;
diff --git a/tests/TestCase.php b/tests/TestCase.php
--- a/tests/TestCase.php
+++ b/tests/TestCase.php
@@ -73,7 +73,7 @@
/**
* Mocks the Phabricator API
*
- * @return Nasqueron\Notifications\Phabricator\PhabricatorAPIFactory The mock
+ * @return \Nasqueron\Notifications\Phabricator\PhabricatorAPIFactory The mock
*/
protected function mockPhabricatorAPI () {
// Inject into our container a mock of PhabricatorAPI
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Jul 28, 17:17 (2 h, 39 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2852148
Default Alt Text
D769.id1948.diff (15 KB)
Attached To
Mode
D769: Improve documentation and code types coherence
Attached
Detach File
Event Timeline
Log In to Comment