Page Menu
Home
DevCentral
Search
Configure Global Search
Log In
Files
F7717976
D164.id391.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D164.id391.diff
View Options
diff --git a/app/Phabricator/PhabricatorStory.php b/app/Phabricator/PhabricatorStory.php
--- a/app/Phabricator/PhabricatorStory.php
+++ b/app/Phabricator/PhabricatorStory.php
@@ -30,7 +30,7 @@
public $type;
/**
- * @var Array
+ * @var array
*/
public $data;
diff --git a/app/Phabricator/ProjectsMap.php b/app/Phabricator/ProjectsMap.php
--- a/app/Phabricator/ProjectsMap.php
+++ b/app/Phabricator/ProjectsMap.php
@@ -141,7 +141,7 @@
/// API
///
- public function fetchFromAPI () {
+ private function fetchFromAPI () {
$reply = PhabricatorAPI::forInstance($this->instance)->call(
'project.query',
[ 'limit' => self::LIMIT ]
@@ -175,7 +175,7 @@
return class_basename(get_class($this)) . '-' . md5($this->instance);
}
- public function isCached () {
+ private function isCached () {
return Cache::has($this->getCacheKey());
}
@@ -214,7 +214,7 @@
/**
* Returns the projects map as an array, each row ['PHID', 'project name']
*
- * @return Array
+ * @return array
*/
public function toArray () {
$array = [];
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, May 2, 15:23 (17 h, 45 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2625158
Default Alt Text
D164.id391.diff (1 KB)
Attached To
Mode
D164: PhabricatorAPI: improve code documentation, scope review
Attached
Detach File
Event Timeline
Log In to Comment