Page MenuHomeDevCentral
Create Task
Maniphest T1679

Upgrade PHP 7.4 base Docker image to recent Debian version
Closed, ResolvedPublic
Actions

Description

Plan is to attack first the base images, then the dependents

Base images

nginx-php7-fpm: ✅
PHP-CLI: still to do

PHP web applications

Notifications Center✅
Auth GroveWe need to upgrade setup-nodesource-deb. Then, install gulp and laravel-elixir
Pixelfed
Cachet
Phabricator✅

PHP CLI applications

Arcanist?

Revisions and Commits

rDPHPVIIFPM Docker image to install nginx, PHP 7 and fpm
D2525rDPHPVIIFPM1c5644246ca2 Move services to /var/service
D2523rDPHPVIIFPMbbffa7c609bd Sync novolume image
D2522rDPHPVIIFPM097a97a166ac Upgrade to Debian Bullseye
D2520rDPHPVIIFPM630b49d9b604 Upgrade to buster using slim image
D2521rDPHPVIIFPMf4465d1a9419 Skip runsvdir-start
D2517rDPHPVIIFPMd3f00350036a Update keyserver to fetch PHP GPG keys
D2518rDPHPVIIFPM65898cea0157 Upgrade Oniguruma to 6.9.7 revised 1
D2519rDPHPVIIFPM0080fd4eb6fc Upgrade to PHP 7.4.27
rDPHPFPM Docker image for Nginx, php-fpm
D2525rDPHPFPM1c5644246ca2 Move services to /var/service
D2523rDPHPFPMbbffa7c609bd Sync novolume image
D2520rDPHPFPM630b49d9b604 Upgrade to buster using slim image
D2522rDPHPFPM097a97a166ac Upgrade to Debian Bullseye
D2521rDPHPFPMf4465d1a9419 Skip runsvdir-start
D2519rDPHPFPM0080fd4eb6fc Upgrade to PHP 7.4.27
rDPHAB Docker image for Phabricator
D2607rDPHAB6b92e3f52200 Move from /etc/service to /var/service
D2606rDPHAB177a045561a2 Upgrade packages names to Debian Bullseyes

Related Objects
Search...

Event Timeline

dereckson triaged this task as High priority.Feb 12 2022, 04:15
dereckson created this task.
dereckson added a parent task: T1547: Consolidate DevCentral Docker image.
dereckson added projects: Docker images, PHP 8.x support.

This blocks T1547, but also is needed to prepare PHP 8.1 repocopy.

dereckson renamed this task from Upgradde PHP 7.4 base Docker image to recent Debian version to Upgrade PHP 7.4 base Docker image to recent Debian version.Feb 12 2022, 04:16
dereckson added a parent task: T1677: Update PHP Docker images to PHP 8.1.
dereckson added a revision: D2520: Upgrade to buster using slim image.
dereckson added commits: rDPHPVIIFPM0080fd4eb6fc: Upgrade to PHP 7.4.27, rDPHPVIIFPM65898cea0157: Upgrade Oniguruma to 6.9.7 revised 1, rDPHPVIIFPMd3f00350036a: Update keyserver to fetch PHP GPG keys.
dereckson added a revision: D2519: Upgrade to PHP 7.4.27.Feb 12 2022, 04:19
dereckson added a revision: D2521: Skip runsvdir-start.Feb 12 2022, 04:27
dereckson added a commit: rDPHPVIIFPMf4465d1a9419: Skip runsvdir-start.Feb 12 2022, 04:29
dereckson added a commit: rDPHPVIIFPM630b49d9b604: Upgrade to buster using slim image.Feb 12 2022, 04:42
dereckson added a comment.Feb 12 2022, 04:50

TODO: novolume/ is still in Jessie, apply rDPHPVIIFPM630b49d9b604 and rDPHPVIIFPMf4465d1a9419 changes here too.

dereckson added a comment.Feb 12 2022, 04:51

Done for the base image (excepted the TODO noted above), we need to test Notifications Center, Auth Grove, etc. against 7.4 deprecations, and if applicable blocks them to 7.2 or 7.3.

dereckson added a revision: D2522: Upgrade to Debian Bullseye.Feb 12 2022, 13:48
dereckson added a commit: rDPHPVIIFPM097a97a166ac: Upgrade to Debian Bullseye.Feb 12 2022, 22:34
dereckson added a revision: D2523: Sync novolume image.Feb 12 2022, 22:40
dereckson added a commit: rDPHPVIIFPMbbffa7c609bd: Sync novolume image.Feb 13 2022, 16:38
dereckson added a comment.Feb 13 2022, 16:42

Done. Last step is to ensure applications dependent of this image works correctly under Buster and Bullseye.

dereckson added a comment.Feb 13 2022, 17:18

On Debian Bullseye, /etc/service is a symlink to /etc/runit/runsvdir/current.

As such:

  • Docker legacy build mode is happy to replace the symlink by a golder
  • BuildKit fails on that operation

BuildKit error

10 ERROR: cannot copy to non-directory: /var/lib/docker/overlay2/u07vvjqbe3xj2absqqzyjue5j/merged/etc/service

I guess BuildKit doesn't check the existence of a file instead of a dir and tries directly to copy the subdirectoryfiles.

Solutions

  • Add rm /etc/service in the build previous step
  • Move files/etc/service to files/etc/runit/runsvdir/current
  • Move files/etc/service to files/var/service, the runit default path, and be independent of Debian package maintainer defaults.
  • Fix it in moby/BuildKit upstream
  • Always build images ourselves without Docker Hub

I'm more inclined to move to /var/service, especially as I wanted to do that before this issue, and to report the issue upstream.

dereckson added a revision: D2525: Move services to /var/service.Feb 13 2022, 17:31
dereckson added a commit: rDPHPVIIFPM1c5644246ca2: Move services to /var/service.Feb 13 2022, 17:32
dereckson added a comment.Feb 13 2022, 17:46

Solution implemented in D2525: we use /var/service.

Issue reported upstream at https://github.com/moby/buildkit/issues/2626

dereckson updated the task description. (Show Details)Feb 13 2022, 22:56
dereckson updated the task description. (Show Details)Feb 14 2022, 01:11
dereckson added a revision: D2606: Upgrade packages names to Debian Bullseye.Mar 19 2022, 22:56
dereckson updated the task description. (Show Details)Mar 19 2022, 22:56
dereckson added a commit: rDPHAB177a045561a2: Upgrade packages names to Debian Bullseyes.Mar 19 2022, 23:01
dereckson added a revision: D2607: Move from /etc/service to /var/service.Mar 19 2022, 23:12
dereckson added a commit: rDPHAB6b92e3f52200: Move from /etc/service to /var/service.Mar 19 2022, 23:14
dereckson moved this task from Backlog to Pending review on the Docker images board.Jan 15 2023, 08:54
dereckson added a commit: rDPHPFPM0080fd4eb6fc: Upgrade to PHP 7.4.27.Feb 27 2023, 20:37
dereckson added a commit: rDPHPFPMf4465d1a9419: Skip runsvdir-start.
dereckson added a commit: rDPHPFPM630b49d9b604: Upgrade to buster using slim image.
dereckson added a commit: rDPHPFPM097a97a166ac: Upgrade to Debian Bullseye.
dereckson added a commit: rDPHPFPMbbffa7c609bd: Sync novolume image.
dereckson added a commit: rDPHPFPM1c5644246ca2: Move services to /var/service.
dereckson closed this task as Resolved.Mar 23 2023, 23:39
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator