Page MenuHomeDevCentral
Create Task
Maniphest T2144

Port Obsidian code to PHP 8.4
Open, NormalPublic
Actions

Description

Obsidian Workspaces has been written as a PHP 7.0 application.

Revisions and Commits

rOBSIDIAN Obsidian Workspaces
D3808rOBSIDIAN581f2a6a447a Define explicitly User::$lastError
D3792rOBSIDIANa4c62d91c42d Use constants in configuration
D3788rOBSIDIAN057258866432 Declare explicitly session properties array in User class
D3778rOBSIDIAN37acd8f09447 Switch Smarty from bundled library to Composer package
D3777rOBSIDIAN2f03838cd1cb Update user-defined error handler signature for PHP 8
D3761rOBSIDIAN17e867de7247 Mark explicitly nullable parameters
D3758rOBSIDIAN5aafe87ceb27 Avoid reserved name get_resource_id

Related Objects

Event Timeline

dereckson triaged this task as Normal priority.Fri, Oct 17, 16:45
dereckson created this task.
dereckson added a project: PHP 8.x support.
dereckson moved this task from Next to Working on on the Obsidian board.Fri, Oct 17, 18:45

This is the priority, before even the CI pipeline.

Just an example: PHP Fatal error: Cannot redeclare function get_resource_id()

We've a global function with the same name than a new function introduced in PHP 8.

dereckson added a revision: D3758: Avoid reserved name get_resource_id.Fri, Oct 17, 20:20
dereckson added a commit: rOBSIDIAN5aafe87ceb27: Avoid reserved name get_resource_id.Fri, Oct 17, 20:47
dereckson added a comment.Sat, Oct 18, 16:23

With 8.4.13, php -l gives:

P375 Syntax check on Obsidian src/ with php -l
1> find */src -type f -name '*.php' | xargs -I {} php -l {} 1> /dev/null
2PHP Deprecated: DatabaseException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/database/DatabaseException.php on line 38
3PHP Deprecated: Database::load(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/database/Database.php on line 35
4PHP Deprecated: MySQLCollection::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/collection/MySQLCollection.php on line 61
5PHP Deprecated: MongoDBCollectionIterator::__construct(): Implicitly marking parameter $cursor as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/collection/MongoDBCollectionIterator.php on line 38
6PHP Deprecated: Smarty_Internal_Resource_File::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_resource_file.php on line 27
7PHP Deprecated: Smarty_CacheResource::process(): Implicitly marking parameter $cached as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_cacheresource.php on line 56
8PHP Deprecated: Smarty_Internal_Resource_Registered::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_resource_registered.php on line 29
9PHP Deprecated: Smarty_Internal_CacheResource_File::process(): Implicitly marking parameter $cached as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_cacheresource_file.php on line 87
10PHP Deprecated: Smarty_Internal_Resource_PHP::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_resource_php.php on line 37
11PHP Deprecated: Smarty_Internal_Resource_Stream::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_resource_stream.php on line 31
12PHP Deprecated: Smarty_Internal_Resource_Eval::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_resource_eval.php on line 30
13PHP Deprecated: Smarty_Resource_Custom::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_resource_custom.php on line 49
14PHP Deprecated: Smarty_Internal_Resource_String::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_resource_string.php on line 30
15PHP Deprecated: Smarty_CacheResource_Custom::process(): Implicitly marking parameter $cached as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_cacheresource_custom.php on line 116
16PHP Deprecated: Smarty_Internal_Resource_Extends::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_internal_resource_extends.php on line 34
17PHP Deprecated: Smarty_CacheResource_KeyValueStore::process(): Implicitly marking parameter $cached as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_cacheresource_keyvaluestore.php on line 87
18PHP Deprecated: Smarty_Resource::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_resource.php on line 83
19PHP Deprecated: Smarty_Resource::buildFilepath(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_resource.php on line 206
20PHP Deprecated: Smarty_Resource::source(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_resource.php on line 521
21PHP Deprecated: Smarty_Resource::source(): Implicitly marking parameter $smarty as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/smarty/sysplugins/smarty_resource.php on line 521
22PHP Deprecated: Language::Load(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in workspaces/src/includes/i18n/Language.php on line 63

dereckson added a revision: D3761: Mark explicitly nullable parameters.Sat, Oct 18, 16:34
dereckson added a commit: rOBSIDIAN17e867de7247: Mark explicitly nullable parameters.Sat, Oct 18, 16:35
dereckson added a comment.Sat, Oct 18, 23:53
This comment was removed by dereckson.
dereckson added a revision: D3777: Update user-defined error handler signature for PHP 8.Sun, Oct 19, 21:18
dereckson added a comment.Sun, Oct 19, 21:20

Database code has been removed, to directly use keruald/database.

Next: drop Smarty from includes/ and load it through Composer.

dereckson added a commit: rOBSIDIAN2f03838cd1cb: Update user-defined error handler signature for PHP 8.Sun, Oct 19, 21:20
dereckson updated the task description. (Show Details)Sun, Oct 19, 21:21
dereckson added a commit: rOBSIDIAN37acd8f09447: Switch Smarty from bundled library to Composer package.Sun, Oct 19, 21:44
dereckson added a revision: D3778: Switch Smarty from bundled library to Composer package.
dereckson added a comment.EditedMon, Oct 20, 19:11
  • [20-Oct-2025 19:10:44 UTC] PHP Deprecated: Creation of dynamic property User::$lastError is deprecated in /var/51-wwwroot/obsidian/workspaces/src/includes/objects/user.php on line 88
  • [20-Oct-2025 19:10:44 UTC] PHP Deprecated: Creation of dynamic property User::$session is deprecated in /var/51-wwwroot/obsidian/workspaces/src/includes/session.php on line 206
dereckson added a revision: D3788: Declare explicitly session properties array in User class.Tue, Oct 21, 19:37
dereckson added a commit: rOBSIDIAN057258866432: Declare explicitly session properties array in User class.Tue, Oct 21, 19:37
dereckson added a revision: D3792: Use constants in configuration.Tue, Oct 21, 20:28
dereckson added a commit: rOBSIDIANa4c62d91c42d: Use constants in configuration.Tue, Oct 21, 20:29
dereckson added a revision: D3808: Define explicitly User::$lastError.Sat, Oct 25, 01:09
dereckson added a commit: rOBSIDIAN581f2a6a447a: Define explicitly User::$lastError.Sat, Oct 25, 01:09
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator