Details

Reviewers

dereckson

Maniphest Tasks

T1695: Write a Terminator plugin to resolve hashes

Summary

This terminator plugin uses resolve-hash module
to solve then redirects to specified commit.

Ref T1695.

Diff Detail

Repository

rRESOLVEHASH Resolve hash

Lint

Lint Errors

Severity	Location	Code	Message
Error	support/terminator/resolve_hash.py:7	E302	flake8 E302
Error	support/terminator/resolve_hash.py:19	E265	flake8 E265
Error	support/terminator/resolve_hash.py:20	E211	flake8 E211
Error	support/terminator/resolve_hash.py:27	E265	flake8 E265
Error	support/terminator/resolve_hash.py:30	E501	flake8 E501
Error	support/terminator/resolve_hash.py:34	F841	flake8 F841
Error	support/terminator/resolve_hash.py:35	E501	flake8 E501
Warning	support/terminator/resolve_hash.py:11	W293	flake8 W293
Warning	support/terminator/resolve_hash.py:17	W293	flake8 W293
Warning	support/terminator/resolve_hash.py:21	W293	flake8 W293
Warning	support/terminator/resolve_hash.py:29	W293	flake8 W293
Warning	support/terminator/resolve_hash.py:33	W293	flake8 W293
Warning	support/terminator/resolve_hash.py:37	W293	flake8 W293

Unit

No Test Coverage

Branch

main

Build Status

Buildable 6360
Build 6644: arc lint + arc unit

Event Timeline

Duranzed requested review of this revision.Mon, Feb 23, 16:23

Duranzed created this revision.

Harbormaster completed remote builds in B6359: Diff 10307.Mon, Feb 23, 16:23

Not for the operations repository, it's for rRESOLVEHASH.

Repository move

@Duranzed Can you try to recreate the commit on a branch on the top of resolve-hash main and try this command?

arc diff --update D3976 HEAD^ -m 'Moving to resolve-hash repository'

dereckson requested changes to this revision.Mon, Feb 23, 17:57

This revision now requires changes to proceed.Mon, Feb 23, 17:57

Moving to resolve-hash repository

Harbormaster completed remote builds in B6360: Diff 10308.Mon, Feb 23, 18:03

Moving to resolve-hash repository

Harbormaster completed remote builds in B6361: Diff 10309.Mon, Feb 23, 18:03

dereckson edited the summary of this revision. (Show Details)Mon, Feb 23, 18:14

dereckson added a task: T1695: Write a Terminator plugin to resolve hashes.

Updated hash resolver plugin for terminator :

Intégration native de resolve-hash
Optimisation des performances
Gestion des erreurs

Harbormaster completed remote builds in B6366: Diff 10315.Tue, Feb 24, 16:42

Plugin works, but we need more metadata:

header on the Python file
explanation in the README how to install it

support/terminator/resolve_hash.py

Header is missing.

I'd suggest something like

#   -------------------------------------------------------------
#   Resolve hash
#   - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
#   Project:        Nasqueron
#   Description:    Terminator plugin to call Resolve hash as
#                   URL handler for longer hashes
#   License:        BSD-2-Clause
#   -------------------------------------------------------------

dereckson requested changes to this revision.Wed, Feb 25, 23:42

This revision now requires changes to proceed.Wed, Feb 25, 23:42

dereckson awarded a token.Wed, Feb 25, 23:42