Using a separate file like /etc/rc.conf.d/netif/carp keeps the CARP configuration isolated,
avoids modifying the main /etc/rc.conf, and makes the setup cleaner and safer.
It improves maintainability, reduces the risk of conflicts, and ensures a more modular infrastructure design.

Harbormaster completed remote builds in B6388: Diff 10340.Mon, Mar 2, 16:24

yousra edited the summary of this revision. (Show Details)Tue, Mar 3, 08:57

yousra added a task: T2264: Implement CARP configuration for router-002 and router-003 .

dereckson edited the summary of this revision. (Show Details)Wed, Mar 4, 07:14

dereckson edited the test plan for this revision. (Show Details)

dereckson retitled this revision from Add CARP configuration in role/router/carp/carp.sls to Add CARP configuration.

dereckson retitled this revision from Add CARP configuration to Configure CARP on routers.

Configuration logic. Looks good to me.

Style: tiny bits of styling comments to help to maintain the configuration.

roles/router/carp/carp.jinja
6 ↗	(On Diff #10340)	Move this file to a subdirectory Perhaps we can use "carp.rc" as filename, so we know it's to configure rc? .jinja extension is only useful to avoid linters on .sh .py etc. to analyse jinja templates as shell script or Python script. For configuration file, that's a problem we don't have Add here the path to that file Example of header: `# Source file: roles/router/carp/files/carp.rc` (so source_path won't be useful, as (1) currently, we can focus on FreeBSD-only for CARP implementation (2) other OS would have received another configuration file as source, so it would have received the source from that file)
9 ↗	(On Diff #10340)	You can merge the two blocks.
23 ↗	(On Diff #10340)	ops/secrets/ is addded automatically by credentials.get_password (that's the prefix shared by all the secrets provisioned through Salt).
29 ↗	(On Diff #10340)	Extra blank line, you can use pre-commit (`make` in your repository) to catch them.
roles/router/carp/carp.sls
8	One extra line