Diff Detail
- Repository
- rOPS Nasqueron Operations
- Lint
Lint Passed - Unit
No Test Coverage - Branch
- GRE-tunnel
- Build Status
Buildable 6491 Build 6775: arc lint + arc unit
Event Timeline
Service part OK.
Configuration needs a better strategy to allow to provision per machine.
| _modules/credentials.py | ||
|---|---|---|
| 304 ↗ | (On Diff #10353) | That's handled in D3987. Perhaps you want to do an arc diff HEAD^ --update D3988 ? |
| pillar/core/network.sls | ||
| 58 ↗ | (On Diff #10353) | We can use the banner format here, to be coherent with the repository style. |
| 73 ↗ | (On Diff #10353) | You can provision them as a follow-up change, uncommented instead. |
| 93 ↗ | (On Diff #10353) | That comment can be safely removed: the pillar name and the ike_ esp_ keys make that clear what is it. |
| roles/core/strongswan/config.sls | ||
| 21 ↗ | (On Diff #10353) | Jinja syntax allows to use dots as separator to access dictionary keys. We can use it, but in that case, it's really coherent to use it everywhere. |
| 22 ↗ | (On Diff #10353) | Won't really work beyond the scope of a test tunnel between those two links. You need a more flexible way to pass the info according the node. Besides, if you deploy this on both router-002 and router-003 you would get twice the config router-002 to router-003 it seems. |
| roles/core/strongswan/files/swanctl.conf | ||
| 1 ↗ | (On Diff #10353) | Header missing, see https://devcentral.nasqueron.org/source/snippets/browse/main/salt/file.conf |
| roles/core/strongswan/init.sls | ||
| 1 ↗ | (On Diff #10353) | Header missing |
| 4 ↗ | (On Diff #10353) | That one doesn't exist in the change it seems |
| roles/core/strongswan/files/swanctl.conf | ||
|---|---|---|
| 50 ↗ | (On Diff #10401) | |
Test to deploy this final version on Complector with a test=True to see if it's still no-op.
| pillar/core/network.sls | ||
|---|---|---|
| 37 ↗ | (On Diff #10513) | We can use explicit variable names. One letter variables is an historical artefact, from the era where the maximal length for a specific code line was fixed. See for example for COBOL this IBM documentation: Nowadays, best practice is to use clear variable name to facilitate reading the code. |
| 9 ↗ | (On Diff #10453) | What's the role of the router? I think it's to get public IP for that node. |