FRRouting (FRR): Installation on routers and activation at boot
AcceptedPublic
Actions

Authored by yousra on Thu, Apr 9, 14:30.

Details

Reviewers

dereckson
Duranzed

Maniphest Tasks

T2303: Installation and configuration of FRRouting

Summary

FRRouting should be installed based on T2208, with OSPF support.

Ref T2303

Test Plan

salt 'router-002' state.apply roles/router
salt 'router-003' state.apply roles/router

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Skipped

Unit

No Test Coverage

Branch

install-frr

Build Status

Buildable 6590
Build 6874: arc lint + arc unit

Event Timeline

yousra requested review of this revision.Thu, Apr 9, 14:30

yousra created this revision.

Harbormaster completed remote builds in B6590: Diff 10587.Thu, Apr 9, 14:30

Let's create a new unit for OSPF and move those in roles/router/frrouting

I'd suggest to adhere to the conventions we used for the last units:

.software for pkg.installed
.config for later configuration
.service for the RC cuisine

For the service, start it, see _resources/templates/service/rc/service.sls for a template to do so

roles/router/carp/init.sls
44	(1) Package name seems to be dependent of OS we target, let's declare it in /map.jinja under a new frrouting key (2) We can actually simplify that one, as by default, the state ID is the value passed implicitly to the `name` parameter: {{ packages.frrouting }}: pkg.installed
48	Should be enclosed in a `{% if services.manager == "rc" %}` condition. Requires an import: `{% from "map.jinja" import services with context %}` (actually `import packages, services`, per previous comment)

This revision now requires changes to proceed.Thu, Apr 9, 17:09

yousra mentioned this in T2303: Installation and configuration of FRRouting.Thu, Apr 9, 18:59

yousra edited the summary of this revision. (Show Details)

yousra added a task: T2303: Installation and configuration of FRRouting.

yousra edited the summary of this revision. (Show Details)Thu, Apr 9, 19:05

yousra retitled this revision from Installation of package frr10 on routers to FRRouting (FRR): Installation on routers and activation at boot .Tue, Apr 14, 18:58

yousra edited the summary of this revision. (Show Details)

Many changes:

Created a new FRRouting unit under roles/router/frrouting
Started structuring the unit FRRouting following conventions:
- software for pkg.installed
- config for configuration files
- service for service management
Moved file frr.rc from roles/router/carp/files to this new unit
Added frrouting package mapping in map.jinja depending on the OS
Simplified package installation using the state ID as name ({{ packages.frrouting }})
Added proper import from map.jinja with packages and services (with context)
Wrapped rc-specific configuration in a condition (services.manager == "rc")