Move get_current_url() and co in OmniTools Request class
ClosedPublic
Actions

Authored by dereckson on Nov 11 2025, 18:13.

Details

Reviewers

Commits

rKOT9e74843a4f7f: Move get_current_url() and co in OmniTools Request class
rKERUALD9917e84c62cb: Move get_current_url() and co in OmniTools Request class

Summary

Those functions lived in Espace Win and Zed code for a very long time
and allow to get the current URL or to build an URL to create a link.

[ Base URL, with or without / ]

Small fixes have been added to allow to append a trailing slash to base URL:
the base URL can so be /subdir or /subdir/

That slash is respected for canonical URL, and ignored for /subdir/any/thing

Test Plan

This code has been battle-tested with several sites using:

direct .php access in the URL
Apache + mod_rewrite
nginx try_files directive

Unit tests have been added to allow leniency on the base URL trailing slash.

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Test Failures

Branch

request-current-url

Build Status

Buildable 6610
Build 6894: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/tests/HTTP/Requests/RequestTest.php
	0 ms	/datacube/dereckson/dev/nasqueron/keruald/keruald/omnitools/tests/HTTP/Requests/RequestWithLocalUrlTest.php

Event Timeline

dereckson requested review of this revision.Nov 11 2025, 18:13

dereckson created this revision.

Harbormaster completed remote builds in B6184: Diff 10049.Nov 11 2025, 18:13

Unit tests still to commit

Comprehensive unit tests. Fixes to allow to add a trailing slash to base URL.

Harbormaster completed remote builds in B6610: Diff 10613.Wed, Apr 15, 16:53

Tests and assertions: +22 (718 -> 740, 2069 -> 2091)

Tests are marked broken because arcanist seems to ignore the backupGlobals="true":

$ phpunit omnitools
Switching to Composer phpunit:
PHPUnit 12.5-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.19
Configuration: /datacube/dereckson/dev/nasqueron/keruald/keruald/phpunit.xml

...............................................................  63 / 740 (  8%)
............................................................... 126 / 740 ( 17%)
............................................................... 189 / 740 ( 25%)
............................................................... 252 / 740 ( 34%)
............................................................... 315 / 740 ( 42%)
............................................................... 378 / 740 ( 51%)
............................................................... 441 / 740 ( 59%)
............................................................... 504 / 740 ( 68%)
............................................................... 567 / 740 ( 76%)
............................................................... 630 / 740 ( 85%)
............................................................... 693 / 740 ( 93%)
...............................................                 740 / 740 (100%)

Time: 00:00.650, Memory: 10.00 MB

OK (740 tests, 2091 assertions)

dereckson retitled this revision from WIP: move get_current_url() and co in OmniTools Request class to Move get_current_url() and co in OmniTools Request class.Wed, Apr 15, 16:55

dereckson edited the summary of this revision. (Show Details)Wed, Apr 15, 16:59

dereckson edited the test plan for this revision. (Show Details)

dereckson accepted this revision.Wed, Apr 15, 19:24

This revision is now accepted and ready to land.Wed, Apr 15, 19:24

This revision was landed with ongoing or failed builds.Wed, Apr 15, 19:31

Closed by commit rKERUALD9917e84c62cb: Move get_current_url() and co in OmniTools Request class (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALD9917e84c62cb: Move get_current_url() and co in OmniTools Request class.

dereckson added a commit: rKOT9e74843a4f7f: Move get_current_url() and co in OmniTools Request class.