Page MenuHomeDevCentral
Differential D440

Document class constants
ClosedPublic
Actions

Authored by dereckson on Jul 1 2016, 19:03.
Tags
None
Referenced Files
F7641213: D440.id1069.diff
Wed, Apr 30, 05:55
Unknown Object (File)
Tue, Apr 29, 17:29
Unknown Object (File)
Thu, Apr 24, 23:11
Unknown Object (File)
Tue, Apr 22, 18:41
Unknown Object (File)
Mon, Apr 21, 04:05
Unknown Object (File)
Fri, Apr 18, 20:12
Unknown Object (File)
Thu, Apr 17, 13:04
Unknown Object (File)
Tue, Apr 15, 23:09
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIF7dc3f5d2a5fe: Document class constants
Summary

Some class constants weren't commented. Now they all are in app/.

Test Plan

Read again the comments, regenerate documentation

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
const-doc

Event Timeline

dereckson updated this revision to Diff 1068.Jul 1 2016, 19:03
dereckson retitled this revision from to Document class constants.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Jul 1 2016, 19:04

Build started: https://ci.nasqueron.org/job/test-notifications-phab/122/ (console: https://ci.nasqueron.org/job/test-notifications-phab/122/console)

alken-orin added a comment.Jul 1 2016, 19:17

Build is green https://ci.nasqueron.org/job/test-notifications-phab/122/ for more details.

dereckson accepted this revision.Jul 1 2016, 19:19
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 19:19
Closed by commit rNOTIF7dc3f5d2a5fe: Document class constants (authored by dereckson, committed by dereckson). · Explain WhyJul 1 2016, 19:19
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Analyzers/
GitHub/
3 lines97%
Loading...
Phabricator/
3 lines90%
Loading...
Http/
Controllers/
Gate/
3 lines--
3 lines--
3 lines--

Diff 1068

View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

Loading...
View Options

app/Analyzers/Phabricator/PhabricatorPayloadAnalyzer.php

Loading...
View Options

app/Http/Controllers/Gate/DockerHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/GitHubGateController.php

Loading...
View Options

app/Http/Controllers/Gate/PhabricatorGateController.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator