Page MenuHomeDevCentral
Differential D4079

Test X-Hub-Signature-256 documentation values
ClosedPublic
Actions

Authored by dereckson on Sat, Apr 18, 13:25.
Tags
None
Referenced Files
F27113212: D4079.id10713.diff
Wed, Apr 29, 06:57
F27112101: D4079.id10645.diff
Wed, Apr 29, 06:34
F27108765: D4079.diff
Wed, Apr 29, 05:42
F27073642: D4079.diff
Tue, Apr 28, 21:54
Unknown Object (File)
Mon, Apr 27, 20:27
Unknown Object (File)
Mon, Apr 27, 20:27
Unknown Object (File)
Mon, Apr 27, 15:35
Unknown Object (File)
Mon, Apr 27, 07:53
View All 42 Files
Subscribers
None

Details

Reviewers
DorianWinty
dereckson
Maniphest Tasks
T2310: Support X-Hub-Signature-256
Commits
rKERUALD976345cd44b6: Demonstrate in tests code is ready for X-Hub-Signature-256
Summary

This change demonstrates in tests the XHubSignature code
is actually ready for X-Hub-Signature-256.

Ref T2310

Test Plan

New unit test provided with a SHA-256 algo

The values of that test are taken from GitHub documentation:
https://docs.github.com/en/webhooks/using-webhooks/validating-webhook-deliveries

Diff Detail

Repository
rKERUALD Keruald libraries development repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Sat, Apr 18, 13:25
dereckson created this revision.
Harbormaster completed remote builds in B6632: Diff 10644.Sat, Apr 18, 13:25
dereckson retitled this revision from Demonstrate in tests code is ready for X-Hub-Signature-256 to Test X-Hub-Signature-256 documentation values.Sat, Apr 18, 13:30
dereckson edited the summary of this revision. (Show Details)

Unit tests

$ phpunit github 
Switching to Composer phpunit:
PHPUnit 12.5-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.30
Configuration: /home/dereckson/dev/keruald/_monorepo/core/phpunit.xml

......                                                              6 / 6 (100%)

Time: 00:00.012, Memory: 16.00 MB

OK (6 tests, 12 assertions)
dereckson updated this revision to Diff 10645.Sat, Apr 18, 13:33

Spacing

Harbormaster completed remote builds in B6633: Diff 10645.Sat, Apr 18, 13:33
dereckson added a child revision: D4086: Add convenience XHubSignature256 class to default to SHA-256.Sun, Apr 19, 18:50
dereckson accepted this revision.Sat, Apr 25, 17:28
This revision is now accepted and ready to land.Sat, Apr 25, 17:28
Closed by commit rKERUALD976345cd44b6: Demonstrate in tests code is ready for X-Hub-Signature-256 (authored by dereckson). · Explain WhySat, Apr 25, 17:30
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rKERUALD976345cd44b6: Demonstrate in tests code is ready for X-Hub-Signature-256.

Revision Contents
Changeset List

PathSize
github/
tests/
7 lines
13 lines

Diff 10713

View Options

github/tests/XHubSignatureConstants.php

Loading...
View Options

github/tests/XHubSignatureTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator