Differential D4174

Don't force to write classes for each document type
ClosedPublic
Actions

Authored by dereckson on Fri, Aug 21, 03:54.

Details

Reviewers

dereckson

Maniphest Tasks

T2144: Port Obsidian code to PHP 8.4

Commits

rOBSIDIANb38fc881b6e7: Don't force to write classes for each document type

Summary

One of the concept of the documents collection is to allow to drop arbitrary
JSON files and get a PHP object from the dictionary fields.

While it's certainly not optimal, and while code could store the properties
in a specific hashmap instead, this attribute is added for compatibility
with PHP 8.2+.

Ref T2144.

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

main

Build Status

Buildable 6817
Build 7105: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Fri, Aug 21, 03:54

dereckson created this revision.

Harbormaster completed remote builds in B6817: Diff 10936.Fri, Aug 21, 03:54

dereckson accepted this revision.Fri, Aug 21, 03:54

This revision is now accepted and ready to land.Fri, Aug 21, 03:54

dereckson edited the summary of this revision. (Show Details)Fri, Aug 21, 03:55

dereckson added a task: T2144: Port Obsidian code to PHP 8.4.

Closed by commit rOBSIDIANb38fc881b6e7: Don't force to write classes for each document type (authored by dereckson). · Explain WhyFri, Aug 21, 03:56

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIANb38fc881b6e7: Don't force to write classes for each document type.

Revision Contents
Changeset List

Path

Size

workspaces/

src/

Engines/

Collection/

CollectionDocument.php

2 lines

Diff 10936

View Options

workspaces/src/Engines/Collection/CollectionDocument.php

Don't force to write classes for each document typeClosedPublicActions