Avoid to throw a PHP warning in addition to throw an exception
ClosedPublic
Actions

Authored by dereckson on Aug 21 2026, 03:58.

Tags

None

Referenced Files

	F53267310: D4175.id10939.diff
	Thu, Oct 8, 02:38

	F53229032: D4175.id10938.diff
	Wed, Oct 7, 21:37

	F53221956: D4175.id10939.diff
	Wed, Oct 7, 20:36

	F53211840: D4175.id10939.diff
	Wed, Oct 7, 19:09

	F53206903: D4175.diff
	Wed, Oct 7, 18:28

	Unknown Object (File)
	Tue, Oct 6, 21:20

	Unknown Object (File)
	Tue, Oct 6, 10:33

	Unknown Object (File)
	Tue, Oct 6, 10:33

View All 70 Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rOBSIDIAN43a0a572f30e: Avoid to throw a PHP warning in addition to throw an exception

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

Test Failures

Branch

main

Build Status

Buildable 6818
Build 7106: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/tmp/obsidian-upgrade/workspaces/tests/Engines/Collection/FilesCollectionTest.php

Event Timeline

dereckson requested review of this revision.Aug 21 2026, 03:58

dereckson created this revision.

Harbormaster completed remote builds in B6818: Diff 10938.Aug 21 2026, 03:58

dereckson accepted this revision.Aug 21 2026, 03:58

This revision is now accepted and ready to land.Aug 21 2026, 03:58

This revision was landed with ongoing or failed builds.Aug 21 2026, 03:58

Closed by commit rOBSIDIAN43a0a572f30e: Avoid to throw a PHP warning in addition to throw an exception (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIAN43a0a572f30e: Avoid to throw a PHP warning in addition to throw an exception.

Revision Contents
Changeset List

Path

Size

workspaces/

src/

Engines/

Collection/

FilesCollection.php

2 lines

Diff 10938

View Options

workspaces/src/Engines/Collection/FilesCollection.php

Avoid to throw a PHP warning in addition to throw an exceptionClosedPublicActions