Page MenuHomeDevCentral
Differential D635

Simplify PhabricatorNotification and allow to use notifications:payload
ClosedPublic
Actions

Authored by dereckson on Aug 24 2016, 02:02.
Tags
None
Referenced Files
F44548363: D635.diff
Mon, Aug 17, 14:14
Unknown Object (File)
Sun, Aug 16, 07:37
Unknown Object (File)
Fri, Aug 14, 23:48
Unknown Object (File)
Fri, Aug 14, 23:05
Unknown Object (File)
Fri, Aug 14, 19:50
Unknown Object (File)
Fri, Aug 14, 16:07
Unknown Object (File)
Fri, Aug 14, 13:53
Unknown Object (File)
Fri, Aug 14, 10:30
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T984: Pick a format for Notifications::$rawContent property
Commits
rNOTIF9e6c1ca7831f: Simplify PhabricatorNotification and allow to use notifications:payload
Summary

With rNOTIF67730e913d04, Phabricator began to match other services.

We continue to simplify Phabricator classes and standardize constructors.

This change allows:

  • to use the notifications:payload command with Phabricator too
  • to use the same rawContent format (inline JSON) than other notifications
Test Plan

php artisan notifications:payload Phabricator storage/logs/PhabricatorPastePayload.json Nasqueron

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1583.Aug 24 2016, 02:02
dereckson retitled this revision from to Allow to use CLI notifications:payload command with Phabricator.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson updated this revision to Diff 1584.Aug 24 2016, 02:12
dereckson edited edge metadata.

More tests

alken-orin added a subscriber: alken-orin.Aug 24 2016, 02:23

Build is green https://ci.nasqueron.org/job/test-notifications-phab/183/ for more details.

alken-orin added a comment.Aug 24 2016, 02:28

Build is green https://ci.nasqueron.org/job/test-notifications-phab/184/ for more details.

dereckson retitled this revision from Allow to use CLI notifications:payload command with Phabricator to Simplify PhabricatorNotification and allow to use notifications:payload.Aug 24 2016, 03:00
dereckson updated this object.
dereckson edited edge metadata.
dereckson added a task: T984: Pick a format for Notifications::$rawContent property.
dereckson accepted this revision.Aug 24 2016, 03:02
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 03:02
dereckson updated this revision to Diff 1585.Aug 24 2016, 03:03
dereckson edited edge metadata.

EOL at EOF

Closed by commit rNOTIF9e6c1ca7831f: Simplify PhabricatorNotification and allow to use notifications:payload (authored by dereckson, committed by dereckson). · Explain WhyAug 24 2016, 03:05
This revision was automatically updated to reflect the committed changes.
alken-orin added a comment.Aug 24 2016, 03:20

Build is green https://ci.nasqueron.org/job/test-notifications-phab/185/ for more details.

Revision Contents
Changeset List

PathSize
app/
Console/
Commands/
19 lines
Notifications/
19 lines
Phabricator/
21 lines
tests/
Console/
Commands/
16 lines
Http/
21 lines
data/
payloads/
1 line

Diff 1586

View Options

app/Console/Commands/NotificationsPayload.php

Loading...
View Options

app/Notifications/PhabricatorNotification.php

Loading...
View Options

app/Phabricator/PhabricatorStory.php

Loading...
View Options

tests/Console/Commands/NotificationsPayloadTest.php

Loading...
View Options

tests/Http/PayloadFullTest.php

Loading...
View Options

tests/data/payloads/PhabricatorPastePayload.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator