Fix type issue in XHubSignature::parseSignature
ClosedPublic
Actions

Authored by dereckson on Jan 7 2017, 06:11.

Tags

None

Referenced Files

	F12381314: D805.diff
	Fri, Oct 31, 15:22

	F12375478: D805.diff
	Thu, Oct 30, 23:46

	Unknown Object (File)
	Tue, Oct 28, 14:24

	Unknown Object (File)
	Fri, Oct 24, 11:39

	Unknown Object (File)
	Mon, Oct 20, 09:43

	Unknown Object (File)
	Tue, Oct 14, 22:45

	Unknown Object (File)
	Tue, Oct 14, 22:45

	Unknown Object (File)
	Tue, Oct 14, 19:16

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKERUALDc0e14492852e: Fix type issue in XHubSignature::parseSignature
rKGHc0e14492852e: Fix type issue in XHubSignature::parseSignature

Summary

This fixes the following issue:

Type error: Return value of
Nasqueron\Notifications\Http\Controllers\Gate\GitHubGateController::getSignature()
must be of the type string, null returned in
/src/app/Http/Controllers/Gate/GitHubGateController.php:114

Diff Detail

Repository

rKGH Keruald GitHub

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson created this revision.Jan 7 2017, 06:11

Harbormaster completed remote builds in B1235: Diff 2040.Jan 7 2017, 06:11

dereckson accepted this revision.Jan 7 2017, 06:12

dereckson added a parent revision: D804: Declare explicitely types.

This revision is now accepted and ready to land.Jan 7 2017, 06:13

Closed by commit rKGHc0e14492852e: Fix type issue in XHubSignature::parseSignature (authored by dereckson, committed by dereckson). · Explain WhyJan 7 2017, 06:15

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALDc0e14492852e: Fix type issue in XHubSignature::parseSignature.Oct 17 2024, 17:15

Revision Contents
Changeset List

Path

Size

XHubSignature.php

4 lines

Diff 2041

View Options

Fix type issue in XHubSignature::parseSignatureClosedPublicActions