Page MenuHomeDevCentral

Refactor Phabricator event and last payload save code
ClosedPublic

Authored by dereckson on Dec 25 2015, 19:53.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 28, 08:37
Unknown Object (File)
Sun, Jul 27, 14:04
Unknown Object (File)
Sun, Jul 27, 03:50
Unknown Object (File)
Sat, Jul 26, 08:23
Unknown Object (File)
Mon, Jul 21, 19:20
Unknown Object (File)
Sun, Jul 20, 23:39
Unknown Object (File)
Fri, Jul 18, 20:51
Unknown Object (File)
Thu, Jul 17, 14:58
Subscribers
None

Details

Summary

The Phabricator event now uses a payload property like the others
...PayloadEvent classes, and is now responsible to initialize
an instance of PhabricatorStory itself.

With a payload property, we are now able to use LastPayloadSaver
for all our payload events.

Test Plan
  • Wait a Phabricator request, check storage/logs/payload.json
  • Same for a GitHub or Docker Hub request

Diff Detail

Repository
rNOTIF Notifications center
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
save-payload
Build Status
Buildable 147
Build 147: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Refactor Phabricator event and last payload save code.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2015, 19:54
This revision was automatically updated to reflect the committed changes.