Paths

Table of Contentst

Differential D1359

Improve cmd.run usage
ClosedPublic
Actions

Authored by dereckson on Feb 28 2018, 15:20.

Tags

None

Referenced Files

	F13468336: D1359.diff
	Sat, Nov 22, 14:30

	F13393263: D1359.diff
	Sat, Nov 22, 01:38

	F13363673: D1359.id3477.diff
	Fri, Nov 21, 20:20

	Unknown Object (File)
	Tue, Nov 18, 12:51

	Unknown Object (File)
	Tue, Nov 18, 11:44

	Unknown Object (File)
	Tue, Nov 18, 11:41

	Unknown Object (File)
	Tue, Nov 18, 11:36

	Unknown Object (File)
	Tue, Nov 18, 07:08

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1349: Use file.managed instead of cmd.run chown/chmod for odderon_fix_permissions_and_ownership

Commits

rOPS69b7ff3224a4: Improve cmd.run usage

Summary

By nature, cmd.run is an imperative order more than a descriptive one.

This change ensures:

file.managed is used to set file modes/ownership
the descriptive creates is used instead of unless: test -f ...

Fixes T1349.

Test Plan

$ salt eglide state.apply roles/shellserver/odderon/config
[…]
Comment: File /opt/odderon/var/darkbot/userlist.db exists with proper permissions. No changes made.
[…]
$ salt eglide state.apply roles/webserver-core/letsencrypt/certificates test=True
[…]
Comment: /etc/letsencrypt/live/www.eglide.org/fullchain.pem exists
[…]

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

clean-cmd-run (branched from master)

Build Status

Buildable 2142
Build 2390: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Feb 28 2018, 15:20

dereckson created this revision.

dereckson accepted this revision.Feb 28 2018, 15:21

This revision is now accepted and ready to land.Feb 28 2018, 15:21

Closed by commit rOPS69b7ff3224a4: Improve cmd.run usage (authored by dereckson). · Explain WhyFeb 28 2018, 15:21

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

shellserver/

odderon/

10 lines

webserver-core/

letsencrypt/

certificates.sls

2 lines

Diff 3477

roles/shellserver/odderon/config.sls

Loading...

roles/webserver-core/letsencrypt/certificates.sls

Loading...