Paths

Table of Contentst

Improve Services class
ClosedPublic
Actions

Authored by dereckson on Jan 4 2016, 20:20.

Tags

None

Referenced Files

	F35006527: D165.id394.diff
	Sun, Jul 5, 22:53

	F35006518: D165.id395.diff
	Sun, Jul 5, 22:53

	F34991271: D165.diff
	Sun, Jul 5, 20:27

	F34977289: D165.id.diff
	Sun, Jul 5, 10:24

	Unknown Object (File)
	Fri, Jul 3, 21:38

	Unknown Object (File)
	Fri, Jul 3, 02:00

	Unknown Object (File)
	Thu, Jul 2, 20:27

	Unknown Object (File)
	Thu, Jul 2, 17:25

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF402dd35f211a: Improve Services class

Summary

removed extraneous return let at testing time
added section comments

Test Plan

php artisan phabricator:projectsmap

Diff Detail

Repository

rNOTIF Notifications center

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

return

Build Status

Buildable 208
Build 208: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 394.Jan 4 2016, 20:20

dereckson retitled this revision from to Improve Services class.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jan 4 2016, 20:21

dereckson mentioned this in D164: PhabricatorAPI: improve code documentation, scope review.

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 4 2016, 20:21

Closed by commit rNOTIF402dd35f211a: Improve Services class (authored by dereckson, committed by dereckson). · Explain WhyJan 4 2016, 20:21

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Services.php

9 lines

Diff 394

View Options

Improve Services classClosedPublicActions