Page MenuHomeDevCentral
Differential D1605

Use an empty string as default encoding argument for encoding
ClosedPublic
Actions

Authored by dereckson on Apr 16 2018, 23:27.
Tags
None
Referenced Files
F26723200: D1605.id4103.diff
Sat, Apr 25, 12:07
F26723121: D1605.diff
Sat, Apr 25, 12:06
F26716463: D1605.id4102.diff
Sat, Apr 25, 09:58
F26683314: D1605.id4103.diff
Fri, Apr 24, 23:39
F26681914: D1605.id4102.diff
Fri, Apr 24, 23:13
Unknown Object (File)
Thu, Apr 23, 18:55
Unknown Object (File)
Sun, Apr 19, 04:07
Unknown Object (File)
Thu, Apr 16, 21:01
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rKOT6a62434da5e7: Use an empty string as default encoding argument for encoding
Summary

Nullable strings can be avoided when an empty string isn't a supported value.

This is a follow-up for 15ddc8ad7a9e.

Test Plan

New tests with default arguments provided.

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Passed
Unit
Tests Passed
Branch
master
Build Status
Buildable 2523
Build 2771: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
Strings/
Multibyte/
4 lines
4 lines
2 lines
tests/
Strings/
Multibyte/
6 lines

Diff 4102

View Options

src/Strings/Multibyte/OmniString.php

Loading...
View Options

src/Strings/Multibyte/StringPad.php

Loading...
View Options

src/Strings/Multibyte/StringUtilities.php

Loading...
View Options

tests/Strings/Multibyte/StringUtilitiesTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator